Consume keycloak-nodejs-connect guides #551
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#550 Signed-off-by: rmartinc <[email protected]>
mposolda
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Approving, but we need to wait until we are sure that ZIPs are available for nightly release and for the latest release. So until these URLs are valid:
- https://github.com/keycloak/keycloak-nodejs-connect/releases/download/nightly/keycloak-nodejs-connect-guides.zip
- https://github.com/keycloak/keycloak-nodejs-connect/releases/download/${version.keycloak-nodejs-connect}/keycloak-nodejs-connect-guides.zip
Especially it will need to wait until keycloak-rel stops doing nightly releases (So probably after keycloak-rel/keycloak-rel#137 ) as nightly releases triggered from keycloak-rel are not adding keycloak-nodejs-connect-guides.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #550
Draft to download and unzip the
keycloak-nodejs-connectguides into the target directory and add those guides for the generation in the web. It uses thedownload-maven-pluginto do that. It's a draft because a final release in thekeycloak-nodejs-connectis needed with the guides zip. Right now it is usingnightlybut I think this is not OK either because keycloak-rel is also creating a nightly tag without the guides zip.