When running with sandboxie, crash happened.

[chinaofmelon]

Source info

• This is from the latest commit in the main branch
• This is from the latest release
• Other

Issue type

• False positive
• Compilation warning/error
• Suggestion
• Other

Environment

• Windows
• Linux
• MacOS
• Other

Description

When running with sandboxie, crash happened, which should not happened.

At brand_list function, when active_count increases, it checks whether the score is greater than 0, but when it decreases, no such check is performed. This results in reading values greater than the size of the array during enumeration.

line: 4355

CLI output (if possible)

[kernelwernel]

Hi! thanks for reporting the issue.

A few things to note:

• line 4355 doesn't point to anything related to brands, I think you got the wrong line number here.
• At what part does it crash? Does it crash in the summary section of the binary or does it crash during the technique execution stage?
• If you got an error message, what does it say?

• At brand_list function, when active_count increases, it checks whether the score is greater than 0, but when it decreases, no such check is performed. This results in reading values greater than the size of the array during enumeration.

Not really, the score variable is related to the percentage, not the score of the brand counts in the brand_list() function. So it's not relevant to the underlying issue.

Can you test again on the latest commit and see if the issue still persists? I made a few changes that should (in theory) fix the crash.

P.S. I deleted the earlier comment due to an unintended runtime error in the previous commit that was supposed to fix the issue, it should be good now. If you see 2 identical notifs of this comment, that's why.