-
Notifications
You must be signed in to change notification settings - Fork 23
Expand file tree
/
Copy pathfork.go
More file actions
546 lines (491 loc) · 17.6 KB
/
Copy pathfork.go
File metadata and controls
546 lines (491 loc) · 17.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
package instances
import (
"bytes"
"context"
"errors"
"fmt"
"hash/crc32"
"os"
"strings"
"time"
"github.com/kernel/hypeman/lib/forkvm"
"github.com/kernel/hypeman/lib/guest"
"github.com/kernel/hypeman/lib/hypervisor"
"github.com/kernel/hypeman/lib/instances/phasetracking"
"github.com/kernel/hypeman/lib/logger"
"github.com/kernel/hypeman/lib/network"
restartpolicy "github.com/kernel/hypeman/lib/restart-policy"
"github.com/nrednav/cuid2"
"go.opentelemetry.io/otel/attribute"
"gvisor.dev/gvisor/pkg/cleanup"
)
// forkInstance creates a new instance by cloning a stopped or standby source
// instance. It returns the newly created fork and the requested final target
// state; callers apply remaining target state transitions outside the source lock.
func (m *manager) forkInstance(ctx context.Context, id string, req ForkInstanceRequest) (_ *Instance, _ State, retErr error) {
log := logger.FromContext(ctx)
log.InfoContext(ctx, "forking instance", "source_instance_id", id, "fork_name", req.Name)
ctx, span := m.startLifecycleSpan(ctx, "instances.fork",
attribute.String("instance_id", id),
attribute.String("operation", "fork"),
)
defer func() { finishInstancesSpan(span, retErr) }()
if err := validateForkRequest(req); err != nil {
return nil, "", err
}
meta, err := m.loadMetadata(id)
if err != nil {
return nil, "", err
}
source := m.toInstance(ctx, meta)
targetState, err := resolveForkTargetState(req.TargetState, source.State)
if err != nil {
return nil, "", err
}
switch source.State {
case StateRunning:
if !req.FromRunning {
return nil, "", fmt.Errorf("%w: cannot fork from state %s (set from_running=true to allow standby+restore flow)", ErrInvalidState, source.State)
}
if err := m.validateForkSupport(ctx, source.HypervisorType); err != nil {
return nil, "", err
}
if err := ensureGuestAgentReadyForRunningFork(ctx, &source.StoredMetadata); err != nil {
return nil, "", err
}
log.InfoContext(ctx, "fork from running requested; transitioning source to standby",
"source_instance_id", id, "hypervisor", source.HypervisorType)
if _, err := m.standbyInstance(ctx, id, StandbyInstanceRequest{}, true); err != nil {
return nil, "", fmt.Errorf("standby source instance: %w", err)
}
forked, forkErr := m.forkInstanceFromStoppedOrStandby(ctx, id, req, true)
if forkErr == nil {
if err := m.rotateSourceVsockForRestore(ctx, id, forked.Id); err != nil {
forkErr = fmt.Errorf("prepare source snapshot for restore: %w", err)
if cleanupErr := m.cleanupForkInstanceOnError(ctx, forked.Id); cleanupErr != nil {
forkErr = fmt.Errorf("%v; additionally failed to cleanup forked instance %s: %v", forkErr, forked.Id, cleanupErr)
}
}
}
// For Firecracker running-source forks, restoring the fork may temporarily alias
// the source data directory. Restore the fork while source remains standby and
// under lock, then restore the source.
if forkErr == nil && targetState == StateRunning {
restoredFork, err := m.applyForkTargetState(ctx, forked.Id, StateRunning)
if err != nil {
forkErr = fmt.Errorf("restore forked instance before source restore: %w", err)
if cleanupErr := m.cleanupForkInstanceOnError(ctx, forked.Id); cleanupErr != nil {
forkErr = fmt.Errorf("%v; additionally failed to cleanup forked instance %s: %v", forkErr, forked.Id, cleanupErr)
}
} else {
forked = restoredFork
}
}
log.InfoContext(ctx, "restoring source instance after running fork", "source_instance_id", id)
_, restoreErr := m.restoreInstance(ctx, id)
if restoreErr != nil {
if forkErr != nil {
return nil, "", fmt.Errorf("fork failed: %v; additionally failed to restore source instance: %w", forkErr, restoreErr)
}
return nil, "", fmt.Errorf("restore source instance after fork: %w", restoreErr)
}
if forkErr != nil {
return nil, "", forkErr
}
return forked, targetState, nil
case StateStopped, StateStandby:
forked, err := m.forkInstanceFromStoppedOrStandby(ctx, id, req, false)
if err != nil {
return nil, "", err
}
return forked, targetState, nil
default:
return nil, "", fmt.Errorf("%w: cannot fork from state %s (must be Stopped or Standby, or Running with from_running=true)", ErrInvalidState, source.State)
}
}
func ensureGuestAgentReadyForRunningFork(ctx context.Context, source *StoredMetadata) error {
return ensureGuestAgentReadyForForkPhase(ctx, source, "before running fork")
}
func ensureGuestAgentReadyForForkPhase(ctx context.Context, inst *StoredMetadata, phase string) error {
if inst == nil || !inst.NetworkEnabled || inst.SkipGuestAgent {
return nil
}
dialer, err := hypervisor.NewVsockDialer(inst.HypervisorType, inst.VsockSocket, inst.VsockCID)
if err != nil {
return fmt.Errorf("create vsock dialer for %s readiness check: %w", phase, err)
}
var stdout, stderr bytes.Buffer
exit, err := guest.ExecIntoInstance(ctx, dialer, guest.ExecOptions{
Command: []string{"true"},
Stdout: &stdout,
Stderr: &stderr,
WaitForAgent: 120 * time.Second,
})
if err != nil {
return fmt.Errorf("wait for guest agent readiness %s: %w", phase, err)
}
if exit.Code != 0 {
return fmt.Errorf(
"guest agent readiness probe failed %s (exit=%d, stdout=%q, stderr=%q)",
phase, exit.Code, strings.TrimSpace(stdout.String()), strings.TrimSpace(stderr.String()),
)
}
return nil
}
func (m *manager) rotateSourceVsockForRestore(ctx context.Context, sourceID, forkID string) error {
meta, err := m.loadMetadata(sourceID)
if err != nil {
return fmt.Errorf("reload source metadata: %w", err)
}
stored := &meta.StoredMetadata
newCID := generateForkSourceVsockCID(sourceID, forkID, stored.VsockCID)
if newCID == stored.VsockCID {
return nil
}
starter, err := m.getVMStarter(stored.HypervisorType)
if err != nil {
return fmt.Errorf("get vm starter: %w", err)
}
prepareResult, err := starter.PrepareFork(ctx, hypervisor.ForkPrepareRequest{
SnapshotConfigPath: m.paths.InstanceSnapshotConfig(sourceID),
VsockCID: newCID,
VsockSocket: stored.VsockSocket,
})
if err != nil {
return fmt.Errorf("rewrite source snapshot vsock state: %w", err)
}
if prepareResult.VsockCIDUpdated {
stored.VsockCID = newCID
if err := m.saveMetadata(meta); err != nil {
return fmt.Errorf("save source metadata: %w", err)
}
}
return nil
}
func generateForkSourceVsockCID(sourceID, forkID string, current int64) int64 {
const cidRange = int64(4294967292)
seed := crc32.ChecksumIEEE([]byte(sourceID + ":" + forkID))
cid := (int64(seed) % cidRange) + 3
if cid == current {
cid = ((cid - 3 + 1) % cidRange) + 3
}
return cid
}
func (m *manager) forkInstanceFromStoppedOrStandby(ctx context.Context, id string, req ForkInstanceRequest, supportValidated bool) (*Instance, error) {
log := logger.FromContext(ctx)
meta, err := m.loadMetadata(id)
if err != nil {
return nil, err
}
source := m.toInstance(ctx, meta)
stored := &meta.StoredMetadata
switch source.State {
case StateStopped, StateStandby:
// allowed
default:
return nil, fmt.Errorf("%w: cannot fork from state %s (must be Stopped or Standby)", ErrInvalidState, source.State)
}
if !supportValidated {
if err := m.validateForkSupport(ctx, stored.HypervisorType); err != nil {
return nil, err
}
}
if err := validateForkVolumeSafety(stored.Volumes); err != nil {
return nil, err
}
existsByMetadata, err := m.instanceNameExists(req.Name)
if err != nil {
return nil, fmt.Errorf("check instance name availability: %w", err)
}
if existsByMetadata {
return nil, fmt.Errorf("%w: instance name '%s' already exists", ErrAlreadyExists, req.Name)
}
if stored.NetworkEnabled {
exists, err := m.networkManager.NameExists(ctx, req.Name, "")
if err != nil {
return nil, fmt.Errorf("check instance name availability: %w", err)
}
if exists {
return nil, fmt.Errorf("%w: instance name '%s' already exists in network", ErrAlreadyExists, req.Name)
}
}
forkID := cuid2.Generate()
if _, err := m.loadMetadata(forkID); err == nil {
return nil, fmt.Errorf("%w: generated fork id already exists", ErrAlreadyExists)
}
srcDir := m.paths.InstanceDir(id)
dstDir := m.paths.InstanceDir(forkID)
cu := cleanup.Make(func() {
_ = os.RemoveAll(dstDir)
})
defer cu.Clean()
if source.State == StateStandby {
if err := m.ensureSnapshotMemoryReady(ctx, m.paths.InstanceSnapshotLatest(id), m.snapshotJobKeyForInstance(id), stored.HypervisorType); err != nil {
return nil, fmt.Errorf("prepare standby snapshot for fork: %w", err)
}
}
if err := forkvm.CopyGuestDirectory(srcDir, dstDir); err != nil {
if errors.Is(err, forkvm.ErrSparseCopyUnsupported) {
return nil, fmt.Errorf("fork requires sparse-capable filesystem (SEEK_DATA/SEEK_HOLE unsupported): %w", err)
}
return nil, fmt.Errorf("clone guest directory: %w", err)
}
starter, err := m.getVMStarter(stored.HypervisorType)
if err != nil {
return nil, fmt.Errorf("get vm starter: %w", err)
}
now := time.Now().UTC()
forkMeta := cloneStoredMetadataWithoutPendingStandbyCompression(meta.StoredMetadata)
forkMeta.Id = forkID
forkMeta.Name = req.Name
forkMeta.CreatedAt = now
forkMeta.StartedAt = nil
forkMeta.StoppedAt = nil
forkMeta.HypervisorPID = nil
forkMeta.SocketPath = m.paths.InstanceSocket(forkID, starter.SocketName())
forkMeta.DataDir = dstDir
forkMeta.VsockSocket = m.paths.InstanceSocket(forkID, hypervisor.VsockSocketNameForType(forkMeta.HypervisorType))
forkMeta.ExitCode = nil
forkMeta.ExitMessage = ""
forkMeta.RestartStatus = restartpolicy.Status{}
// Forks are new instances; phase accounting must not inherit the source's
// cumulative durations. The first transition into the fork's runtime
// phase (Standby for snapshot forks, Stopped for stopped forks) will be
// recorded by the appropriate operation when the fork is acted on.
forkMeta.Phases.Reset()
switch source.State {
case StateStandby:
forkMeta.Phases.Record(phasetracking.PhaseStandby, now)
case StateStopped:
forkMeta.Phases.Record(phasetracking.PhaseStopped, now)
}
// Keep the original CID for snapshot-based forks.
// Rewriting CID in restored memory snapshots is not reliable across
// hypervisors.
if source.State == StateStandby {
forkMeta.VsockCID = stored.VsockCID
} else {
forkMeta.VsockCID = generateVsockCID(forkID)
}
if forkMeta.NetworkEnabled {
// Clear inherited network identity. For stopped instances this is regenerated on start,
// and for standby instances restore allocates if identity is empty.
forkMeta.IP = ""
forkMeta.MAC = ""
}
if source.State == StateStandby {
snapshotConfigPath := m.paths.InstanceSnapshotConfig(forkID)
netCfg := (*hypervisor.ForkNetworkConfig)(nil)
if forkMeta.NetworkEnabled {
netCfg = &hypervisor.ForkNetworkConfig{TAPDevice: network.GenerateTAPName(forkID)}
}
if _, err := starter.PrepareFork(ctx, hypervisor.ForkPrepareRequest{
SnapshotConfigPath: snapshotConfigPath,
SourceDataDir: stored.DataDir,
TargetDataDir: forkMeta.DataDir,
VsockCID: forkMeta.VsockCID,
VsockSocket: forkMeta.VsockSocket,
SerialLogPath: m.paths.InstanceAppLog(forkID),
Network: netCfg,
}); err != nil {
if errors.Is(err, hypervisor.ErrNotSupported) {
return nil, fmt.Errorf("%w: fork is not supported for hypervisor %s", ErrNotSupported, stored.HypervisorType)
}
return nil, fmt.Errorf("prepare fork snapshot state: %w", err)
}
}
newMeta := &metadata{StoredMetadata: forkMeta}
if err := m.saveMetadata(newMeta); err != nil {
return nil, fmt.Errorf("save fork metadata: %w", err)
}
cu.Release()
forked := m.toInstance(ctx, newMeta)
log.InfoContext(ctx, "instance forked successfully",
"source_instance_id", id,
"fork_instance_id", forked.Id,
"fork_name", forked.Name,
"state", forked.State)
return &forked, nil
}
func (m *manager) validateForkSupport(ctx context.Context, hvType hypervisor.Type) error {
starter, err := m.getVMStarter(hvType)
if err != nil {
return fmt.Errorf("get vm starter: %w", err)
}
if _, err := starter.PrepareFork(ctx, hypervisor.ForkPrepareRequest{}); err != nil {
if errors.Is(err, hypervisor.ErrNotSupported) {
return fmt.Errorf("%w: fork is not supported for hypervisor %s", ErrNotSupported, hvType)
}
return fmt.Errorf("prepare fork state: %w", err)
}
return nil
}
func validateForkRequest(req ForkInstanceRequest) error {
if err := validateInstanceName(req.Name); err != nil {
return fmt.Errorf("%w: %v", ErrInvalidRequest, err)
}
if req.TargetState != "" && req.TargetState != StateStopped && req.TargetState != StateStandby && req.TargetState != StateRunning {
return fmt.Errorf("%w: invalid fork target state %q (must be one of %s, %s, %s)", ErrInvalidRequest, req.TargetState, StateStopped, StateStandby, StateRunning)
}
return nil
}
func validateForkVolumeSafety(volumes []VolumeAttachment) error {
for _, vol := range volumes {
if !vol.Readonly {
return fmt.Errorf("%w: cannot fork instance with writable volume %q mounted at %q; use readonly+overlay for safe concurrent forks", ErrNotSupported, vol.VolumeID, vol.MountPath)
}
}
return nil
}
func resolveForkTargetState(requested State, sourceState State) (State, error) {
if requested == "" {
switch sourceState {
case StateRunning, StateStandby, StateStopped:
return sourceState, nil
default:
return "", fmt.Errorf("%w: cannot derive fork target state from source state %s", ErrInvalidState, sourceState)
}
}
return requested, nil
}
func (m *manager) applyForkTargetState(ctx context.Context, forkID string, target State) (*Instance, error) {
lock := m.getInstanceLock(forkID)
lock.Lock()
defer lock.Unlock()
returnWithReadiness := func(inst *Instance, err error) (*Instance, error) {
if err != nil {
return nil, err
}
if inst != nil && (inst.State == StateRunning || inst.State == StateInitializing) {
if err := ensureGuestAgentReadyForForkPhase(ctx, &inst.StoredMetadata, "before returning running fork instance"); err != nil {
return nil, fmt.Errorf("wait for forked guest agent readiness: %w", err)
}
}
return inst, nil
}
current, err := m.getInstance(ctx, forkID)
if err != nil {
return nil, err
}
if current.State == target || (target == StateRunning && current.State == StateInitializing) {
return returnWithReadiness(current, nil)
}
switch current.State {
case StateStopped:
switch target {
case StateRunning:
return returnWithReadiness(m.startInstance(ctx, forkID, StartInstanceRequest{}))
case StateStandby:
if _, err := m.startInstance(ctx, forkID, StartInstanceRequest{}); err != nil {
return nil, fmt.Errorf("start forked instance for standby transition: %w", err)
}
return returnWithReadiness(m.standbyInstance(ctx, forkID, StandbyInstanceRequest{}, false))
}
case StateStandby:
switch target {
case StateRunning:
return returnWithReadiness(m.restoreInstance(ctx, forkID))
case StateStopped:
if err := os.RemoveAll(m.paths.InstanceSnapshotLatest(forkID)); err != nil {
return nil, fmt.Errorf("remove fork snapshot: %w", err)
}
return returnWithReadiness(m.getInstance(ctx, forkID))
}
case StateRunning:
switch target {
case StateStandby:
return returnWithReadiness(m.standbyInstance(ctx, forkID, StandbyInstanceRequest{}, false))
case StateStopped:
return returnWithReadiness(m.stopInstance(ctx, forkID))
}
}
return nil, fmt.Errorf("%w: cannot transition forked instance from %s to %s", ErrInvalidState, current.State, target)
}
func (m *manager) cleanupForkInstanceOnError(ctx context.Context, forkID string) error {
lock := m.getInstanceLock(forkID)
lock.Lock()
defer lock.Unlock()
err := m.deleteInstance(ctx, forkID)
if err == nil || errors.Is(err, ErrNotFound) {
m.instanceLocks.Delete(forkID)
return nil
}
return err
}
func cloneStoredMetadata(src StoredMetadata) StoredMetadata {
dst := src
dst.PendingStandbyCompression = clonePendingStandbyCompression(src.PendingStandbyCompression)
if src.Env != nil {
dst.Env = make(map[string]string, len(src.Env))
for k, v := range src.Env {
dst.Env[k] = v
}
}
if src.NetworkEgress != nil {
dst.NetworkEgress = cloneNetworkEgressPolicy(src.NetworkEgress)
}
if src.AutoStandby != nil {
dst.AutoStandby = cloneAutoStandbyPolicy(src.AutoStandby)
}
if src.HealthCheck != nil {
dst.HealthCheck = cloneHealthCheckPolicy(src.HealthCheck)
}
if src.RestartPolicy != nil {
dst.RestartPolicy = cloneRestartPolicy(src.RestartPolicy)
}
if src.SnapshotPolicy != nil {
dst.SnapshotPolicy = cloneSnapshotPolicy(src.SnapshotPolicy)
}
if src.Credentials != nil {
dst.Credentials = cloneCredentialPolicies(src.Credentials)
}
if src.Tags != nil {
dst.Tags = make(map[string]string, len(src.Tags))
for k, v := range src.Tags {
dst.Tags[k] = v
}
}
if src.Volumes != nil {
dst.Volumes = append([]VolumeAttachment(nil), src.Volumes...)
}
if src.Devices != nil {
dst.Devices = append([]string(nil), src.Devices...)
}
if src.Entrypoint != nil {
dst.Entrypoint = append([]string(nil), src.Entrypoint...)
}
if src.Cmd != nil {
dst.Cmd = append([]string(nil), src.Cmd...)
}
if src.HypervisorPID != nil {
pid := *src.HypervisorPID
dst.HypervisorPID = &pid
}
if src.StartedAt != nil {
startedAt := *src.StartedAt
dst.StartedAt = &startedAt
}
if src.StoppedAt != nil {
stoppedAt := *src.StoppedAt
dst.StoppedAt = &stoppedAt
}
if src.ProgramStartedAt != nil {
programStartedAt := *src.ProgramStartedAt
dst.ProgramStartedAt = &programStartedAt
}
if src.GuestAgentReadyAt != nil {
guestAgentReadyAt := *src.GuestAgentReadyAt
dst.GuestAgentReadyAt = &guestAgentReadyAt
}
if src.ExitCode != nil {
exitCode := *src.ExitCode
dst.ExitCode = &exitCode
}
dst.Phases = src.Phases.Clone()
return dst
}
func cloneStoredMetadataWithoutPendingStandbyCompression(src StoredMetadata) StoredMetadata {
dst := cloneStoredMetadata(src)
dst.PendingStandbyCompression = nil
return dst
}