Skip to content

Commit 30546b0

Browse files
committed
fix: allow replays list/download for deleted browser sessions
The CLI was calling GET /browsers/{id} before listing or downloading replays, which returns 404 for deleted sessions. Skip that lookup and pass the session ID directly to the replay endpoints, which already work for deleted sessions. Fixes KERNEL-1098
1 parent a3de2ca commit 30546b0

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

cmd/browsers.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,11 +1092,7 @@ func (b BrowsersCmd) ReplaysList(ctx context.Context, in BrowsersReplaysListInpu
10921092
return fmt.Errorf("unsupported --output value: use 'json'")
10931093
}
10941094

1095-
br, err := b.browsers.Get(ctx, in.Identifier, kernel.BrowserGetParams{})
1096-
if err != nil {
1097-
return util.CleanedUpSdkError{Err: err}
1098-
}
1099-
items, err := b.replays.List(ctx, br.SessionID)
1095+
items, err := b.replays.List(ctx, in.Identifier)
11001096
if err != nil {
11011097
return util.CleanedUpSdkError{Err: err}
11021098
}
@@ -1165,11 +1161,7 @@ func (b BrowsersCmd) ReplaysStop(ctx context.Context, in BrowsersReplaysStopInpu
11651161
}
11661162

11671163
func (b BrowsersCmd) ReplaysDownload(ctx context.Context, in BrowsersReplaysDownloadInput) error {
1168-
br, err := b.browsers.Get(ctx, in.Identifier, kernel.BrowserGetParams{})
1169-
if err != nil {
1170-
return util.CleanedUpSdkError{Err: err}
1171-
}
1172-
res, err := b.replays.Download(ctx, in.ReplayID, kernel.BrowserReplayDownloadParams{ID: br.SessionID})
1164+
res, err := b.replays.Download(ctx, in.ReplayID, kernel.BrowserReplayDownloadParams{ID: in.Identifier})
11731165
if err != nil {
11741166
return util.CleanedUpSdkError{Err: err}
11751167
}

0 commit comments

Comments
 (0)