Skip to content

Commit 8a7df62

Browse files
committed
selftests/bpf: Add tests for prog streams
Add selftests to stress test the various facets of the stream API, memory allocation pattern, and ensuring dumping support is tested and functional. Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]>
1 parent f7ddb5d commit 8a7df62

File tree

3 files changed

+204
-0
lines changed

3 files changed

+204
-0
lines changed
Lines changed: 112 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,112 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */
3+
#include <test_progs.h>
4+
#include <sys/mman.h>
5+
6+
#include "stream.skel.h"
7+
#include "stream_fail.skel.h"
8+
9+
void test_stream_failure(void)
10+
{
11+
RUN_TESTS(stream_fail);
12+
}
13+
14+
void test_stream_success(void)
15+
{
16+
RUN_TESTS(stream);
17+
return;
18+
}
19+
20+
struct {
21+
int prog_off;
22+
const char *errstr;
23+
} stream_error_arr[] = {
24+
{
25+
offsetof(struct stream, progs.stream_cond_break),
26+
"ERROR: Timeout detected for may_goto instruction",
27+
},
28+
{
29+
offsetof(struct stream, progs.stream_deadlock),
30+
"ERROR: AA or ABBA deadlock detected",
31+
},
32+
};
33+
34+
void test_stream_errors(void)
35+
{
36+
LIBBPF_OPTS(bpf_test_run_opts, opts);
37+
LIBBPF_OPTS(bpf_prog_stream_read_opts, ropts);
38+
struct stream *skel;
39+
int ret, prog_fd;
40+
char buf[64];
41+
42+
skel = stream__open_and_load();
43+
if (!ASSERT_OK_PTR(skel, "stream__open_and_load"))
44+
return;
45+
46+
for (int i = 0; i < ARRAY_SIZE(stream_error_arr); i++) {
47+
struct bpf_program **prog;
48+
49+
prog = (struct bpf_program **)(((char *)skel) + stream_error_arr[i].prog_off);
50+
prog_fd = bpf_program__fd(*prog);
51+
ret = bpf_prog_test_run_opts(prog_fd, &opts);
52+
ASSERT_OK(ret, "ret");
53+
ASSERT_OK(opts.retval, "retval");
54+
55+
#if !defined(__x86_64__)
56+
ASSERT_TRUE(1, "Timed may_goto unsupported, skip.");
57+
if (i == 0) {
58+
ret = bpf_prog_stream_read(prog_fd, 2, buf, sizeof(buf), &ropts);
59+
ASSERT_EQ(ret, 0, "stream read");
60+
continue;
61+
}
62+
#endif
63+
64+
ret = bpf_prog_stream_read(prog_fd, BPF_STREAM_STDERR, buf, sizeof(buf), &ropts);
65+
ASSERT_EQ(ret, sizeof(buf), "stream read");
66+
ASSERT_STRNEQ(stream_error_arr[i].errstr, buf, strlen(stream_error_arr[i].errstr),
67+
"compare error msg");
68+
}
69+
70+
stream__destroy(skel);
71+
}
72+
73+
void test_stream_syscall(void)
74+
{
75+
LIBBPF_OPTS(bpf_test_run_opts, opts);
76+
LIBBPF_OPTS(bpf_prog_stream_read_opts, ropts);
77+
struct stream *skel;
78+
int ret, prog_fd;
79+
char buf[64];
80+
81+
skel = stream__open_and_load();
82+
if (!ASSERT_OK_PTR(skel, "stream__open_and_load"))
83+
return;
84+
85+
prog_fd = bpf_program__fd(skel->progs.stream_syscall);
86+
ret = bpf_prog_test_run_opts(prog_fd, &opts);
87+
ASSERT_OK(ret, "ret");
88+
ASSERT_OK(opts.retval, "retval");
89+
90+
ASSERT_LT(bpf_prog_stream_read(0, BPF_STREAM_STDOUT, buf, sizeof(buf), &ropts), 0, "error");
91+
ret = -errno;
92+
ASSERT_EQ(ret, -EINVAL, "bad prog_fd");
93+
94+
ASSERT_LT(bpf_prog_stream_read(prog_fd, 0, buf, sizeof(buf), &ropts), 0, "error");
95+
ret = -errno;
96+
ASSERT_EQ(ret, -ENOENT, "bad stream id");
97+
98+
ASSERT_LT(bpf_prog_stream_read(prog_fd, BPF_STREAM_STDOUT, NULL, sizeof(buf), NULL), 0, "error");
99+
ret = -errno;
100+
ASSERT_EQ(ret, -EFAULT, "bad stream buf");
101+
102+
ret = bpf_prog_stream_read(prog_fd, BPF_STREAM_STDOUT, buf, 2, NULL);
103+
ASSERT_EQ(ret, 2, "bytes");
104+
ret = bpf_prog_stream_read(prog_fd, BPF_STREAM_STDOUT, buf, 2, NULL);
105+
ASSERT_EQ(ret, 2, "bytes");
106+
ret = bpf_prog_stream_read(prog_fd, BPF_STREAM_STDOUT, buf, 1, &ropts);
107+
ASSERT_EQ(ret, 0, "no bytes stdout");
108+
ret = bpf_prog_stream_read(prog_fd, BPF_STREAM_STDERR, buf, 1, &ropts);
109+
ASSERT_EQ(ret, 0, "no bytes stderr");
110+
111+
stream__destroy(skel);
112+
}
Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */
3+
#include <vmlinux.h>
4+
#include <bpf/bpf_tracing.h>
5+
#include <bpf/bpf_helpers.h>
6+
#include "bpf_misc.h"
7+
#include "bpf_experimental.h"
8+
9+
struct arr_elem {
10+
struct bpf_res_spin_lock lock;
11+
};
12+
13+
struct {
14+
__uint(type, BPF_MAP_TYPE_ARRAY);
15+
__uint(max_entries, 1);
16+
__type(key, int);
17+
__type(value, struct arr_elem);
18+
} arrmap SEC(".maps");
19+
20+
#define ENOSPC 28
21+
#define _STR "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
22+
23+
#define STREAM_STR (u64)(_STR _STR _STR _STR)
24+
25+
SEC("syscall")
26+
__success __retval(0)
27+
int stream_exhaust(void *ctx)
28+
{
29+
bpf_repeat(BPF_MAX_LOOPS)
30+
if (bpf_stream_printk(BPF_STDOUT, _STR) == -ENOSPC)
31+
return 0;
32+
return 1;
33+
}
34+
35+
SEC("syscall")
36+
__success __retval(0)
37+
int stream_cond_break(void *ctx)
38+
{
39+
while (can_loop)
40+
;
41+
return 0;
42+
}
43+
44+
SEC("syscall")
45+
__success __retval(0)
46+
int stream_deadlock(void *ctx)
47+
{
48+
struct bpf_res_spin_lock *lock, *nlock;
49+
50+
lock = bpf_map_lookup_elem(&arrmap, &(int){0});
51+
if (!lock)
52+
return 0;
53+
nlock = bpf_map_lookup_elem(&arrmap, &(int){0});
54+
if (!nlock)
55+
return 0;
56+
if (bpf_res_spin_lock(lock))
57+
return 0;
58+
if (bpf_res_spin_lock(nlock)) {
59+
bpf_res_spin_unlock(lock);
60+
return 0;
61+
}
62+
bpf_res_spin_unlock(nlock);
63+
bpf_res_spin_unlock(lock);
64+
return 0;
65+
}
66+
67+
SEC("syscall")
68+
__success __retval(0)
69+
int stream_syscall(void *ctx)
70+
{
71+
bpf_stream_printk(BPF_STDOUT, "foo");
72+
return 0;
73+
}
74+
75+
char _license[] SEC("license") = "GPL";
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */
3+
#include <vmlinux.h>
4+
#include <bpf/bpf_tracing.h>
5+
#include <bpf/bpf_helpers.h>
6+
#include <bpf/bpf_core_read.h>
7+
#include "bpf_misc.h"
8+
9+
SEC("syscall")
10+
__failure __msg("Possibly NULL pointer passed")
11+
int stream_vprintk_null_arg(void *ctx)
12+
{
13+
bpf_stream_vprintk(BPF_STDOUT, "", NULL, 0, NULL);
14+
return 0;
15+
}
16+
17+
char _license[] SEC("license") = "GPL";

0 commit comments

Comments
 (0)