Skip to content

Commit 83f066f

Browse files
Dan Carpenterbroonie
authored andcommitted
spi: stm32-ospi: clean up on error in probe()
If reset_control_acquire() fails, then we can't return directly. We need to do a little clean up first. Fixes: cf2c3ec ("spi: stm32-ospi: Make usage of reset_control_acquire/release() API") Signed-off-by: Dan Carpenter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent bd30b99 commit 83f066f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/spi/spi-stm32-ospi.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,8 +937,10 @@ static int stm32_ospi_probe(struct platform_device *pdev)
937937
goto err_pm_enable;
938938

939939
ret = reset_control_acquire(ospi->rstc);
940-
if (ret)
941-
return dev_err_probe(dev, ret, "Can not acquire reset %d\n", ret);
940+
if (ret) {
941+
dev_err_probe(dev, ret, "Can not acquire reset %d\n", ret);
942+
goto err_pm_resume;
943+
}
942944

943945
reset_control_assert(ospi->rstc);
944946
udelay(2);

0 commit comments

Comments
 (0)