Skip to content

Commit 6a8faf1

Browse files
laoarborkmann
authored andcommitted
bpftool: Fix build warnings with -Wtype-limits
Quentin reported build warnings when building bpftool : link.c: In function ‘perf_config_hw_cache_str’: link.c:86:18: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 86 | if ((id) >= 0 && (id) < ARRAY_SIZE(array)) \ | ^~ link.c:320:20: note: in expansion of macro ‘perf_event_name’ 320 | hw_cache = perf_event_name(evsel__hw_cache, config & 0xff); | ^~~~~~~~~~~~~~~ [... more of the same for the other calls to perf_event_name ...] He also pointed out the reason and the solution: We're always passing unsigned, so it should be safe to drop the check on (id) >= 0. Fixes: 62b57e3 ("bpftool: Add perf event names") Reported-by: Quentin Monnet <[email protected]> Suggested-by: Quentin Monnet <[email protected]> Signed-off-by: Yafang Shao <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Acked-by: Quentin Monnet <[email protected]> Closes: https://lore.kernel.org/bpf/[email protected] Link: https://lore.kernel.org/bpf/[email protected]
1 parent 32337c0 commit 6a8faf1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/bpf/bpftool/link.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ const char *evsel__hw_cache_result[PERF_COUNT_HW_CACHE_RESULT_MAX] = {
8383
#define perf_event_name(array, id) ({ \
8484
const char *event_str = NULL; \
8585
\
86-
if ((id) >= 0 && (id) < ARRAY_SIZE(array)) \
86+
if ((id) < ARRAY_SIZE(array)) \
8787
event_str = array[id]; \
8888
event_str; \
8989
})

0 commit comments

Comments
 (0)