Skip to content

Attempt at solving issue with both Arc and Brave resolving to the same short name #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasbn wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Attempt at solving issue with both Arc and Brave resolving to the same short name #32

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b4fbd8
Now doing translation between 'browser' and 'arc' for human consumpti…
jonasbn Jan 25, 2025
ce116ba
Now we support both arc and brave
jonasbn Jan 28, 2025
3bd0734
Rolled back some experimental changes, which are also present in othe…
jonasbn Jan 28, 2025
a5100a8
Rolled back some experimental changes, which are also present in othe…
jonasbn Jan 28, 2025
75f92c6
Removed a unused variable, previously used for
jonasbn Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/main.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,19 @@
#import <ApplicationServices/ApplicationServices.h>

NSString* app_name_from_bundle_id(NSString *app_bundle_id) {
return [[[app_bundle_id componentsSeparatedByString:@"."] lastObject] lowercaseString];

NSString *handler = app_bundle_id;
NSString *shortname = @"";

if ([handler caseInsensitiveCompare:@"company.thebrowser.Browser"] == NSOrderedSame) {
shortname = @"arc";
} else if ([handler caseInsensitiveCompare:@"com.brave.Browser"] == NSOrderedSame) {
shortname = @"brave";
} else {
shortname = [[[app_bundle_id componentsSeparatedByString:@"."] lastObject] lowercaseString];
}

return shortname;
}

NSMutableDictionary* get_http_handlers() {
Expand All @@ -20,7 +32,10 @@

for (int i = 0; i < [handlers count]; i++) {
NSString *handler = [handlers objectAtIndex:i];
dict[app_name_from_bundle_id(handler)] = handler;

NSString *shortname = app_name_from_bundle_id(handler);

dict[shortname] = handler;
}

return dict;
Expand Down Expand Up @@ -59,19 +74,18 @@ int main(int argc, const char *argv[]) {
printf("%s%s\n", mark, [key UTF8String]);
}
} else {
NSString *target_handler_name = [NSString stringWithUTF8String:target];

if ([target_handler_name caseInsensitiveCompare:current_handler_name] == NSOrderedSame) {
printf("%s is already set as the default HTTP handler\n", target);
if ([target caseInsensitiveCompare:current_handler_name] == NSOrderedSame) {
printf("%s is already set as the default HTTP handler\n", [target UTF8String]);
} else {
NSString *target_handler = handlers[target_handler_name];
NSString *target_handler = handlers[target];

if (target_handler != nil) {
// Set new HTTP handler (HTTP and HTTPS separately)
set_default_handler(@"http", target_handler);
set_default_handler(@"https", target_handler);
} else {
printf("%s is not available as an HTTP handler\n", target);
printf("%s is not available as an HTTP handler\n", [target UTF8String]);

return 1;
}
Expand Down