Have one file per feature and writing the CODEOWNERS file

[gabrieldemarmiesse]

By feature, I mean layer/optimizer/callback/example/model/... etc.

This is necessary to achieve #416 . So we have to change the structure of the repo and move code to do that.

Note that there should be a 1:1 mapping between the structure of the the keras-contrib/keras_contrib directory and the keras-contrib/tests/keras_contrib directory. So we need to move the tests accordingly.

[RaphaelMeudec]

Here is the list of elements that should be tackled in this issue (might have missed some elements):

• CosineDense layer in core.py should be renamed to cosine_dense.py
• CosineConvolution2D is also exported as CosineConv2D. I'm not convinced about the benefits of doing that
• keras_contrib.tests should be moved to test/keras_contrib
• keras_contrib.utils.tests should be moved to test/keras_contrib/utils

Also, some missing tests :

• Missing test_snapshot.py for snapshot callback
• Missing test_clip.py for clip constraint
• Empty test_datasets.py file
• Missing test_convolution_aware.py for convolution aware initializer
• Missing test_crf_losses.py for crf losses
• Missing test_crf_accuracies
• Missing test_conv_utils

Other files with multiple features in it, but not sure we should split them:

• in Applications, Densenet with various depth (161, 264, ..)
• in Losses, crf losses
• in Metrics, crf accuracies

[gabrieldemarmiesse]

We still need CosineConv2D, it's to be consistent with the keras naming conventions, otherwise all other changes seems good. Better to split them into multiple PRs if possible.

…

On Sun, 3 Mar 2019, 18:26 Raphael Meudec, ***@***.***> wrote: Here is the list of elements that should be tackled in this issue (might have missed some elements): - CosineDense layer in core.py should be renamed to cosine_dense.py - CosineConvolution2D is also exported as CosineConv2D. I'm not convinced about the benefits of doing that - keras_contrib.tests should be moved to test/keras_contrib - keras_contrib.utils.tests should be moved to test/keras_contrib/utils Also, some missing tests : - Missing test_snapshot.py for snapshot callback - Missing test_clip.py for clip constraint - Empty test_datasets.py file - Missing test_convolution_aware.py for convolution aware initializer - Missing test_crf_losses.py for crf losses - Missing test_crf_accuracies - Missing conv_utils Other files with multiple features in it, but not sure we should split them: - in Applications, Densenet with various depth (161, 264, ..) - in Losses, crf losses - in Metrics, crf accuracies — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#417 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMS2KyYj-OFfZwAuy5JyQIoQI4gWOgOGks5vTAWqgaJpZM4agHT9> .