Skip to content

Commit c945725

Browse files
committed
Rollup merge of rust-lang#49158 - varkor:compiletest-triples, r=rkruppe
Make compiletest do exact matching on triples This avoids the issues of the previous substring matching, ensuring `ARCH_TABLE` and `OS_TABLE` will no longer contain redundant entries. Fixes rust-lang#48893. r? @rkruppe
2 parents 20eaf35 + 61e1fbc commit c945725

7 files changed

+36
-7
lines changed

src/test/codegen/abi-main-signature-16bit-c-int.rs

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
// ignore-mips
2020
// ignore-mips64
2121
// ignore-powerpc
22+
// ignore-powerpc64
2223
// ignore-s390x
2324
// ignore-sparc
2425
// ignore-wasm32

src/test/codegen/fastcall-inreg.rs

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
// ignore-mips
2424
// ignore-mips64
2525
// ignore-msp430
26+
// ignore-powerpc64
27+
// ignore-powerpc64le
2628
// ignore-powerpc
2729
// ignore-r600
2830
// ignore-amdgcn

src/test/codegen/global_asm.rs

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
// ignore-mips
2020
// ignore-mips64
2121
// ignore-msp430
22+
// ignore-powerpc64
23+
// ignore-powerpc64le
2224
// ignore-powerpc
2325
// ignore-r600
2426
// ignore-amdgcn

src/test/codegen/global_asm_include.rs

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
// ignore-mips
2020
// ignore-mips64
2121
// ignore-msp430
22+
// ignore-powerpc64
23+
// ignore-powerpc64le
2224
// ignore-powerpc
2325
// ignore-r600
2426
// ignore-amdgcn

src/test/codegen/global_asm_x2.rs

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
// ignore-mips
2020
// ignore-mips64
2121
// ignore-msp430
22+
// ignore-powerpc64
23+
// ignore-powerpc64le
2224
// ignore-powerpc
2325
// ignore-r600
2426
// ignore-amdgcn

src/test/codegen/repr-transparent-aggregates-1.rs

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
// ignore-mips
1515
// ignore-mips64
1616
// ignore-powerpc
17+
// ignore-powerpc64
1718
// See repr-transparent.rs
1819

1920
#![crate_type="lib"]

src/tools/compiletest/src/util.rs

+26-7
Original file line numberDiff line numberDiff line change
@@ -14,42 +14,59 @@ use common::Config;
1414
/// Conversion table from triple OS name to Rust SYSNAME
1515
const OS_TABLE: &'static [(&'static str, &'static str)] = &[
1616
("android", "android"),
17+
("androideabi", "android"),
1718
("bitrig", "bitrig"),
1819
("cloudabi", "cloudabi"),
1920
("darwin", "macos"),
2021
("dragonfly", "dragonfly"),
22+
("emscripten", "emscripten"),
2123
("freebsd", "freebsd"),
24+
("fuchsia", "fuchsia"),
2225
("haiku", "haiku"),
2326
("ios", "ios"),
27+
("l4re", "l4re"),
2428
("linux", "linux"),
2529
("mingw32", "windows"),
2630
("netbsd", "netbsd"),
2731
("openbsd", "openbsd"),
32+
("redox", "redox"),
33+
("solaris", "solaris"),
2834
("win32", "windows"),
2935
("windows", "windows"),
30-
("solaris", "solaris"),
31-
("emscripten", "emscripten"),
3236
];
3337

3438
const ARCH_TABLE: &'static [(&'static str, &'static str)] = &[
3539
("aarch64", "aarch64"),
3640
("amd64", "x86_64"),
3741
("arm", "arm"),
3842
("arm64", "aarch64"),
43+
("armv4t", "arm"),
44+
("armv5te", "arm"),
45+
("armv7", "arm"),
46+
("armv7s", "arm"),
47+
("asmjs", "asmjs"),
3948
("hexagon", "hexagon"),
4049
("i386", "x86"),
4150
("i586", "x86"),
4251
("i686", "x86"),
43-
("mips64", "mips64"),
4452
("mips", "mips"),
53+
("mips64", "mips64"),
54+
("mips64el", "mips64"),
55+
("mipsel", "mips"),
4556
("msp430", "msp430"),
4657
("powerpc", "powerpc"),
58+
("powerpc64", "powerpc64"),
59+
("powerpc64le", "powerpc64"),
4760
("s390x", "s390x"),
4861
("sparc", "sparc"),
62+
("sparc64", "sparc64"),
63+
("sparcv9", "sparc64"),
64+
("thumbv6m", "thumb"),
65+
("thumbv7em", "thumb"),
66+
("thumbv7m", "thumb"),
67+
("wasm32", "wasm32"),
4968
("x86_64", "x86_64"),
5069
("xcore", "xcore"),
51-
("asmjs", "asmjs"),
52-
("wasm32", "wasm32"),
5370
];
5471

5572
pub fn matches_os(triple: &str, name: &str) -> bool {
@@ -58,16 +75,18 @@ pub fn matches_os(triple: &str, name: &str) -> bool {
5875
if triple == "wasm32-unknown-unknown" {
5976
return name == "emscripten" || name == "wasm32-bare"
6077
}
78+
let triple: Vec<_> = triple.split('-').collect();
6179
for &(triple_os, os) in OS_TABLE {
62-
if triple.contains(triple_os) {
80+
if triple.contains(&triple_os) {
6381
return os == name;
6482
}
6583
}
6684
panic!("Cannot determine OS from triple");
6785
}
6886
pub fn get_arch(triple: &str) -> &'static str {
87+
let triple: Vec<_> = triple.split('-').collect();
6988
for &(triple_arch, arch) in ARCH_TABLE {
70-
if triple.contains(triple_arch) {
89+
if triple.contains(&triple_arch) {
7190
return arch;
7291
}
7392
}

0 commit comments

Comments
 (0)