Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seed recordings with matching ISRCs for new releases #78

Open
reubot opened this issue Dec 12, 2024 · 1 comment
Open

seed recordings with matching ISRCs for new releases #78

reubot opened this issue Dec 12, 2024 · 1 comment
Labels
feature New feature or request seeding MusicBrainz seeding

Comments

@reubot
Copy link
Contributor

reubot commented Dec 12, 2024

suggested next step is to seed recordings with matching ISRCs for new releases

I agree that this would be useful, especially for compilations.
It probably isn't as straightforward as this PR, because we have to be careful not to use recordings where the ISRCs are ambiguous and the user should be able to opt out.
Can you create a ticket to discuss this feature in detail?
Depending on the implementation, it might even make the MB links from this PR useless 😅

Originally posted by @kellnerd in #77 (review)

@reubot reubot changed the title seed recordings with matching ISRCs for new releases when MB provider is checked seed recordings with matching ISRCs for new releases Dec 12, 2024
@reubot
Copy link
Contributor Author

reubot commented Dec 12, 2024

I agree that this would be useful, especially for compilations. It probably isn't as straightforward as this PR, because we have to be careful not to use recordings where the ISRCs are ambiguous and the user should be able to opt out.

I suggest that this would only be used if MB has been selected as a provider, thus providing an way to opt out.

it might even make the MB links from this PR useless 😅

I think the link would be still be useful for ambiguous recordings (as mentioned before).

@kellnerd kellnerd added feature New feature or request seeding MusicBrainz seeding labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request seeding MusicBrainz seeding
Projects
None yet
Development

No branches or pull requests

2 participants