Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup button on release lookup page doesn't save the cookies #72

Open
RustyNova016 opened this issue Nov 19, 2024 · 2 comments
Open

Lookup button on release lookup page doesn't save the cookies #72

RustyNova016 opened this issue Nov 19, 2024 · 2 comments
Labels
question Further information is requested web Web interface

Comments

@RustyNova016
Copy link
Contributor

When clicking on the "lookup" button while already being in the release lookup page doesn't save the cookies. You need to go to the main page to set them

Before
image

After clicking "lookup"
image

@kellnerd kellnerd added question Further information is requested web Web interface labels Nov 20, 2024
@kellnerd
Copy link
Owner

This is intended behavior because you are on an active lookup page, i.e. you have already submitted a non-empty lookup form/request.
The checkboxes only persist state changes on inactive lookup pages, like the homepage and an empty release lookup page.

The idea is that this behavior allows you to modify your provider selection for the current lookup only, for example if there is a tracklist or barcode incompatibility and you have to disable some provider(s) to be able to proceed. I thought it would be annoying if these temporary changes would be remembered for the next lookup.

This behavior has been present right from the start when the checkboxes were only persisted to local storage and is still the same now that there are additional cookies.
I admit that this is not very obvious as the checkboxes look exactly the same as they do on an empty form. Maybe there should be some visual indicator, but I have no idea how that should look like without cluttering the page too much?

Let me know if that makes sense to you, or if you would rather have a consistent checkbox behavior, even if that means you have to "reset" the checkboxes to your standard preferences after each special case lookup.

@RustyNova016
Copy link
Contributor Author

Well I mostly think about users that only go to harmony by userscripts and thus never see the front page (like me). I do think that temporarly editing the providers without messing up the preference is pretty useful, so maybe add a checkbox to toggle the feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested web Web interface
Projects
None yet
Development

No branches or pull requests

2 participants