implicit sorting instead

Author: roman.atachiants@careem.com

sorted/codecs.go

@@ -135,21 +135,12 @@ func (c *uintSliceCodec) DecodeTo(d *binary.Decoder, rv reflect.Value) (err erro
 
 // ------------------------------------------------------------------------------
 
-// TimestampCodec returns a timestamp codec.
-func TimestampCodec(sort bool) binary.Codec {
-	return &timestampCodec{
-		sort: sort,
-	}
-}
-
-type timestampCodec struct {
-	sort bool // Whether codec needs to sort or not
-}
+type timestampCodec struct{}
 
 // EncodeTo encodes a value into the encoder.
 func (c timestampCodec) EncodeTo(e *binary.Encoder, rv reflect.Value) (err error) {
 	data := rv.Interface().(Timestamps)
-	if c.sort {
+	if !sort.IsSorted(Uint64s(data)) {
 		sort.Sort(Uint64s(data))
 	}
 

sorted/codecs_test.go

@@ -62,12 +62,12 @@ func BenchmarkSortedSlice(b *testing.B) {
 
 /*
 cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
-BenchmarkTimes/encode-12         	  238062	      4586 ns/op	    3337 B/op	       5 allocs/op
-BenchmarkTimes/decode-12         	  202978	      6026 ns/op	    8219 B/op	       2 allocs/op
+BenchmarkTimes/encode-12         	   17698	     76181 ns/op	   30893 B/op	       6 allocs/op
+BenchmarkTimes/decode-12         	   22126	     54699 ns/op	   81977 B/op	       2 allocs/op
 */
 func BenchmarkTimes(b *testing.B) {
 	var times Timestamps
-	for i := uint64(0); i < 1000; i++ {
+	for i := uint64(0); i < 10000; i++ {
 		times = append(times, uint64(time.Now().Unix())+i)
 	}
 	enc, _ := binary.Marshal(&times)

sorted/types.go

@@ -100,5 +100,5 @@ type Timestamps []uint64
 
 // GetBinaryCodec retrieves a custom binary codec.
 func (ts *Timestamps) GetBinaryCodec() binary.Codec {
-	return TimestampCodec(true)
+	return timestampCodec{}
 }