Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Consider renaming requester to redeemer #311

Closed
liamzebedee opened this issue Oct 6, 2019 · 3 comments
Closed

Consider renaming requester to redeemer #311

liamzebedee opened this issue Oct 6, 2019 · 3 comments

Comments

@liamzebedee
Copy link
Contributor

It seems that requester in all places of redemption/liquidation logic, could be more clearly described as the redeemer.

See context on the liquidation PR.
@prestwich
Copy link
Contributor

historical context: I avoided this due to religious connotations 😆

@mhluongo
Copy link
Member

mhluongo commented Oct 7, 2019

I avoided this due to religious connotations

... me too 😀

@liamzebedee
Copy link
Contributor Author

I'm not even sure if this relates to angering Christians or just the Ethereum communities 🤔😆

@liamzebedee liamzebedee mentioned this issue Jan 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhluongo @liamzebedee @prestwich