Skip to content

Using SensitiveHeaders doesn't work for StoreRequest with LoggerStore #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wow-such-amazing opened this issue Apr 2, 2025 · 1 comment

Comments

@wow-such-amazing
Copy link

Hey there!

Thanks a lot for the library, it's an amazing way to look into the logs on device!

I've wanted to enable logs in our app store builds to have a bit more info available on device if needed. And I wanted to leverage usage of NetworkLogger.Configuration for that.

It does redact sensitive data when using URLSessionProxy, but it doesn't work when using LoggerStore.shared.storeRequest. And we have to use it as we are actually using Apollo library for GraphQL communication. And they don't provide a way to inject a URLSession.

I guess one option I have right now is to redact those fields in the request and response on my own?

Cheers!

@wow-such-amazing
Copy link
Author

@kean I've created a PR that should address the issue! I didn't test it yet as would like to hear your thoughts, but it compiles and there nothing fancy 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant