Skip to content

Commit 5d47f58

Browse files
lansusekdave
authored andcommitted
btrfs-progs: tests: add execution permission and warning messages
Running test misc/056 results in no output, because the script lacked execution permissions. To prevent this to accidentally happen: - fix permissions in misc-tests/056-subvolume-list-uuid/test.sh - add warning message if test.sh without execution permission in the test driver scripts, the exception are fuzz-tests where not all directories contain the test.sh Pull-request: #994 [ Update changelog. ] Signed-off-by: David Sterba <[email protected]>
1 parent 7aa089a commit 5d47f58

File tree

6 files changed

+9
-1
lines changed

6 files changed

+9
-1
lines changed

tests/cli-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ do
7474
fi
7575
_fail "test failed for case $name"
7676
fi
77+
else
78+
_fail "custom test script not found or lacks execution permission"
7779
fi
7880
cd "$TEST_TOP"
7981
done

tests/convert-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ run_one_test() {
8585
fi
8686
check_test_results "$RESULTS" "$testname"
8787
else
88-
_fail "custom test script not found"
88+
_fail "custom test script not found or lacks execution permission"
8989
fi
9090
}
9191

tests/fuzz-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ do
7373
fi
7474
_fail "test failed for case $(basename $i)"
7575
fi
76+
else
77+
_not_run "custom test script not found or lacks execution permission"
7678
fi
7779
cd "$TEST_TOP"
7880
done

tests/misc-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ do
8181
_fail "test failed for case $(basename $i)"
8282
fi
8383
check_test_results "$RESULTS" "$name"
84+
else
85+
_fail "custom test script not found or lacks execution permission"
8486
fi
8587
cd "$TEST_TOP"
8688
done

tests/misc-tests/056-subvolume-list-uuid/test.sh

100644100755
File mode changed.

tests/mkfs-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ do
7676
_fail "test failed for case $name"
7777
fi
7878
check_test_results "$RESULTS" "$name"
79+
else
80+
_fail "custom test script not found or lacks execution permission"
7981
fi
8082
cd "$TEST_TOP"
8183
done

0 commit comments

Comments
 (0)