Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient width of LyricSpriteText causes crashes #2315

Open
CloneWith opened this issue Jan 20, 2025 · 2 comments
Open

Insufficient width of LyricSpriteText causes crashes #2315

CloneWith opened this issue Jan 20, 2025 · 2 comments

Comments

@CloneWith
Copy link
Contributor

This originates from an exception I frequently encountered when inspecting TestSceneTranslationsScreen. When I scroll the lyric list nearly down to the bottom, the test client would crash out.

Somehow after I reviewed relevant code and the example karaoke test file, it seems that when the lyric is too long to display in one line, the framework would fail to compute the positioning of characters. (Likely in computeCharacters() of your customized osu!framework)

Since I'm pretty inexperienced in the development of basic framework components, I couldn't give much idea on this. 🤯 Would spliting them into multiple lines help?

@andy840119
Copy link
Member

I didn't have this issue before, could you provide the video or the beatmap you are using?

@CloneWith
Copy link
Contributor Author

CloneWith commented Jan 20, 2025

Image

The karaoke-file-samples beatmap in the repository I think... The last line would cause a crash.

Partial text

@[04:05:28]La [04:05:46]La [04:05:65]La [04:05:85]La [04:06:01]La [04:06:20]La [04:06:40]La~~ [04:07:51]La [04:08:13]La~~~~~~~~~~~[04:11:52]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants