Skip to content
This repository was archived by the owner on Apr 5, 2020. It is now read-only.

Commit fa61018

Browse files
committed
Avoid PHP warning if an incorrect payload is received
1 parent a356bcd commit fa61018

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

Plugin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function getPluginAuthor()
5454

5555
public function getPluginVersion()
5656
{
57-
return '1.0.4';
57+
return '1.0.5';
5858
}
5959

6060
public function getPluginHomepage()

WebhookHandler.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ public function parsePayload($type, array $payload)
7575
*/
7676
public function parsePushEvent(array $payload)
7777
{
78+
if (empty($payload['commits'])) {
79+
return false;
80+
}
81+
7882
foreach ($payload['commits'] as $commit) {
7983
$task_id = $this->taskModel->getTaskIdFromText($commit['message']);
8084

@@ -115,6 +119,10 @@ public function parsePushEvent(array $payload)
115119
*/
116120
public function parseIssueEvent(array $payload)
117121
{
122+
if (empty($payload['action'])) {
123+
return false;
124+
}
125+
118126
switch ($payload['action']) {
119127
case 'opened':
120128
return $this->handleIssueOpened($payload['issue']);
@@ -144,6 +152,10 @@ public function parseIssueEvent(array $payload)
144152
*/
145153
public function parseCommentIssueEvent(array $payload)
146154
{
155+
if (empty($payload['issue'])) {
156+
return false;
157+
}
158+
147159
$task = $this->taskFinderModel->getByReference($this->project_id, $payload['issue']['number']);
148160

149161
if (! empty($task)) {

0 commit comments

Comments
 (0)