Skip to content

Commit c9edfc1

Browse files
claustresclaustres
committed
fix: HTTP task with overwrite set to false still try to request data (#294)
1 parent 11e1a24 commit c9edfc1

File tree

3 files changed

+52
-16
lines changed

3 files changed

+52
-16
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
"feathers-mongodb": "^6.0.0",
122122
"loader-runner": "^3.0.0",
123123
"mocha": "^9.0.0",
124-
"nock": "^12.0.0",
124+
"nock": "^14.0.0",
125125
"shx": "^0.3.2",
126126
"standard": "^17.0.0",
127127
"stylus-loader": "^3.0.2",

‎test/tasks.test.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,6 @@ describe('krawler:tasks', () => {
9494
.timeout(10000)
9595

9696
it('creates a HTTP task without overwrite', async () => {
97-
nock('https://www.google.com')
98-
.get('/')
99-
.reply(200, '<html></html>')
10097
await tasksService.create({
10198
id: 'task.html',
10299
store: 'test-store',

‎yarn.lock‎

Lines changed: 51 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,18 @@
344344
dependencies:
345345
sparse-bitfield "^3.0.3"
346346

347+
"@mswjs/interceptors@^0.39.5":
348+
version "0.39.8"
349+
resolved "https://registry.yarnpkg.com/@mswjs/interceptors/-/interceptors-0.39.8.tgz#0a2cf4cf26a731214ca4156273121f67dff7ebf8"
350+
integrity sha512-2+BzZbjRO7Ct61k8fMNHEtoKjeWI9pIlHFTqBwZ5icHpqszIgEZbjb1MW5Z0+bITTCTl3gk4PDBxs9tA/csXvA==
351+
dependencies:
352+
"@open-draft/deferred-promise" "^2.2.0"
353+
"@open-draft/logger" "^0.3.0"
354+
"@open-draft/until" "^2.0.0"
355+
is-node-process "^1.2.0"
356+
outvariant "^1.4.3"
357+
strict-event-emitter "^0.5.1"
358+
347359
"@npmcli/agent@^2.0.0":
348360
version "2.2.2"
349361
resolved "https://registry.yarnpkg.com/@npmcli/agent/-/agent-2.2.2.tgz#967604918e62f620a648c7975461c9c9e74fc5d5"
@@ -391,6 +403,24 @@
391403
resolved "https://registry.yarnpkg.com/@oozcitak/util/-/util-8.3.8.tgz#10f65fe1891fd8cde4957360835e78fd1936bfdd"
392404
integrity sha512-T8TbSnGsxo6TDBJx/Sgv/BlVJL3tshxZP7Aq5R1mSnM5OcHY2dQaxLMu2+E8u3gN0MLOzdjurqN4ZRVuzQycOQ==
393405

406+
"@open-draft/deferred-promise@^2.2.0":
407+
version "2.2.0"
408+
resolved "https://registry.yarnpkg.com/@open-draft/deferred-promise/-/deferred-promise-2.2.0.tgz#4a822d10f6f0e316be4d67b4d4f8c9a124b073bd"
409+
integrity sha512-CecwLWx3rhxVQF6V4bAgPS5t+So2sTbPgAzafKkVizyi7tlwpcFpdFqq+wqF2OwNBmqFuu6tOyouTuxgpMfzmA==
410+
411+
"@open-draft/logger@^0.3.0":
412+
version "0.3.0"
413+
resolved "https://registry.yarnpkg.com/@open-draft/logger/-/logger-0.3.0.tgz#2b3ab1242b360aa0adb28b85f5d7da1c133a0954"
414+
integrity sha512-X2g45fzhxH238HKO4xbSr7+wBS8Fvw6ixhTDuvLd5mqh6bJJCFAPwU9mPDxbcrRtfxv4u5IHCEH77BmxvXmmxQ==
415+
dependencies:
416+
is-node-process "^1.2.0"
417+
outvariant "^1.4.0"
418+
419+
"@open-draft/until@^2.0.0":
420+
version "2.1.0"
421+
resolved "https://registry.yarnpkg.com/@open-draft/until/-/until-2.1.0.tgz#0acf32f470af2ceaf47f095cdecd40d68666efda"
422+
integrity sha512-U69T3ItWHvLwGg5eJ0n3I62nWuE6ilHlmz7zM0npLBRvPRd7e6NYmg54vvRtP5mZG7kZqZCFVdsTWo7BPtBujg==
423+
394424
"@pkgjs/parseargs@^0.11.0":
395425
version "0.11.0"
396426
resolved "https://registry.yarnpkg.com/@pkgjs/parseargs/-/parseargs-0.11.0.tgz#a77ea742fab25775145434eb1d2328cf5013ac33"
@@ -4754,6 +4784,11 @@ is-negative-zero@^2.0.2:
47544784
resolved "https://registry.yarnpkg.com/is-negative-zero/-/is-negative-zero-2.0.2.tgz#7bf6f03a28003b8b3965de3ac26f664d765f3150"
47554785
integrity sha512-dqJvarLawXsFbNDeJW7zAz8ItJ9cd28YufuuFzh0G8pNHjJMnY08Dv7sYX2uF5UpQOwieAeOExEYAWWfu7ZZUA==
47564786

4787+
is-node-process@^1.2.0:
4788+
version "1.2.0"
4789+
resolved "https://registry.yarnpkg.com/is-node-process/-/is-node-process-1.2.0.tgz#ea02a1b90ddb3934a19aea414e88edef7e11d134"
4790+
integrity sha512-Vg4o6/fqPxIjtxgUH5QLJhwZ7gW5diGCVlXpuUfELC62CuxM1iHcRe51f2W1FDy04Ai4KJkagKjx3XaqyfRKXw==
4791+
47574792
is-number-object@^1.0.4:
47584793
version "1.0.7"
47594794
resolved "https://registry.yarnpkg.com/is-number-object/-/is-number-object-1.0.7.tgz#59d50ada4c45251784e9904f5246c742f07a42fc"
@@ -5241,7 +5276,7 @@ lodash.reduce@4.6.0:
52415276
version "4.6.0"
52425277
resolved "https://registry.yarnpkg.com/lodash.reduce/-/lodash.reduce-4.6.0.tgz#f1ab6b839299ad48f784abbf476596f03b914d3b"
52435278

5244-
lodash@^4.0.0, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4:
5279+
lodash@^4.0.0, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4:
52455280
version "4.17.21"
52465281
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
52475282
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
@@ -5688,14 +5723,13 @@ nocache@2.0.0:
56885723
version "2.0.0"
56895724
resolved "https://registry.yarnpkg.com/nocache/-/nocache-2.0.0.tgz#202b48021a0c4cbde2df80de15a17443c8b43980"
56905725

5691-
nock@^12.0.0:
5692-
version "12.0.3"
5693-
resolved "https://registry.yarnpkg.com/nock/-/nock-12.0.3.tgz#83f25076dbc4c9aa82b5cdf54c9604c7a778d1c9"
5694-
integrity sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==
5726+
nock@^14.0.0:
5727+
version "14.0.10"
5728+
resolved "https://registry.yarnpkg.com/nock/-/nock-14.0.10.tgz#d6f4e73e1c6b4b7aa19d852176e68940e15cd19d"
5729+
integrity sha512-Q7HjkpyPeLa0ZVZC5qpxBt5EyLczFJ91MEewQiIi9taWuA0KB/MDJlUWtON+7dGouVdADTQsf9RA7TZk6D8VMw==
56955730
dependencies:
5696-
debug "^4.1.0"
5731+
"@mswjs/interceptors" "^0.39.5"
56975732
json-stringify-safe "^5.0.1"
5698-
lodash "^4.17.13"
56995733
propagate "^2.0.0"
57005734

57015735
node-domexception@^1.0.0:
@@ -5978,6 +6012,11 @@ osmtogeojson@^3.0.0-beta.3:
59786012
optionalDependencies:
59796013
"@types/geojson" "^1.0.2"
59806014

6015+
outvariant@^1.4.0, outvariant@^1.4.3:
6016+
version "1.4.3"
6017+
resolved "https://registry.yarnpkg.com/outvariant/-/outvariant-1.4.3.tgz#221c1bfc093e8fec7075497e7799fdbf43d14873"
6018+
integrity sha512-+Sl2UErvtsoajRDKCE5/dBz4DIvHXQQnAxtQTF04OJxY0+DyZXSo5P5Bb7XYWOh81syohlYL24hbDwxedPUJCA==
6019+
59816020
p-limit@^1.1.0:
59826021
version "1.1.0"
59836022
resolved "https://registry.yarnpkg.com/p-limit/-/p-limit-1.1.0.tgz#b07ff2d9a5d88bec806035895a2bab66a27988bc"
@@ -7365,6 +7404,11 @@ stream-shift@^1.0.0:
73657404
version "1.0.0"
73667405
resolved "https://registry.yarnpkg.com/stream-shift/-/stream-shift-1.0.0.tgz#d5c752825e5367e786f78e18e445ea223a155952"
73677406

7407+
strict-event-emitter@^0.5.1:
7408+
version "0.5.1"
7409+
resolved "https://registry.yarnpkg.com/strict-event-emitter/-/strict-event-emitter-0.5.1.tgz#1602ece81c51574ca39c6815e09f1a3e8550bd93"
7410+
integrity sha512-vMgjE/GGEPEFnhFub6pa4FmJBRBVOLpIII2hvCZ8Kzb7K0hlHo7mQv6xYrBvCL2LtAIBwFUK8wvuJgTVSQ5MFQ==
7411+
73687412
"string-width-cjs@npm:string-width@^4.2.0":
73697413
version "4.2.3"
73707414
resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
@@ -8330,11 +8374,6 @@ xmlbuilder@~9.0.1:
83308374
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-9.0.7.tgz#132ee63d2ec5565c557e20f4c22df9aca686b10d"
83318375
integrity sha1-Ey7mPS7FVlxVfiD0wi35rKaGsQ0=
83328376

8333-
xmldom@^0.6.0:
8334-
version "0.6.0"
8335-
resolved "https://registry.yarnpkg.com/xmldom/-/xmldom-0.6.0.tgz#43a96ecb8beece991cef382c08397d82d4d0c46f"
8336-
integrity sha512-iAcin401y58LckRZ0TkI4k0VSM1Qg0KGSc3i8rU+xrxe19A/BN1zHyVSJY7uoutVlaTSzYyk/v5AmkewAP7jtg==
8337-
83388377
xmldom@~0.1.16:
83398378
version "0.1.27"
83408379
resolved "https://registry.yarnpkg.com/xmldom/-/xmldom-0.1.27.tgz#d501f97b3bdb403af8ef9ecc20573187aadac0e9"

0 commit comments

Comments
 (0)