You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If so, how should we deal with the configuration (parameters to NewResourceFactory?)
If it is a singleton, should all the modules that need it hold a reference to it and pass it down to their dependent objects or call a global GetInstance() function that returns the global instance?
The text was updated successfully, but these errors were encountered:
The issue of possibly refactoring the resourceFactory has come up a couple of times.
Opening this issue do discuss it. Some discussion topics could be:
resourceFactory
be a singleton? That seems to be the current intention but I frankly doubt that's the actual case looking at the code:sriov-network-device-plugin/pkg/factory/factory.go
Lines 39 to 49 in 89b9bc9
If so, how should we deal with the configuration (parameters to
NewResourceFactory
?)The text was updated successfully, but these errors were encountered: