Skip to content

Commit 6a2e62b

Browse files
authored
Merge pull request FasterXML#969 from k163377/organize-deprecateds
Cleanup of deprecated contents
2 parents b9776d4 + b0afcc0 commit 6a2e62b

File tree

6 files changed

+12
-15
lines changed

6 files changed

+12
-15
lines changed

pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,11 @@
245245
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
246246
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
247247
<excludes>
248+
<!-- public -->
249+
<!-- removed -->
250+
<exclude>
251+
com.fasterxml.jackson.module.kotlin.MissingKotlinParameterException#MissingKotlinParameterException(kotlin.reflect.KParameter,java.io.Closeable,java.lang.String)
252+
</exclude>
248253
</excludes>
249254
</parameter>
250255
</configuration>

release-notes/CREDITS-2.x

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Contributors:
1818
# 2.20.0 (not yet released)
1919

2020
WrongWrong (@k163377)
21+
* #969: Cleanup of deprecated contents
2122
* #967: Update settings for 2.20
2223

2324
# 2.19.1 (not yet released)

release-notes/VERSION-2.x

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Co-maintainers:
1818

1919
2.20.0 (not yet released)
2020

21+
#969: Deprecated content has been cleaned up with the version upgrade.
2122
#967: Kotlin has been upgraded to 2.0.21.
2223

2324
2.19.1 (not yet released)

src/main/kotlin/com/fasterxml/jackson/module/kotlin/Exceptions.kt

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package com.fasterxml.jackson.module.kotlin
33
import com.fasterxml.jackson.core.JsonParser
44
import com.fasterxml.jackson.databind.JsonMappingException
55
import com.fasterxml.jackson.databind.exc.InvalidNullException
6-
import java.io.Closeable
76
import kotlin.reflect.KParameter
87

98
/**
@@ -31,15 +30,4 @@ class MissingKotlinParameterException(
3130
val parameter: KParameter,
3231
processor: JsonParser? = null,
3332
msg: String
34-
) : InvalidNullException(processor, msg, null) {
35-
@Deprecated(
36-
"Use main constructor, ",
37-
ReplaceWith("MissingKotlinParameterException(KParameter, JsonParser?, String)"),
38-
DeprecationLevel.ERROR,
39-
)
40-
constructor(
41-
parameter: KParameter,
42-
processor: Closeable? = null,
43-
msg: String
44-
) : this(parameter, processor as JsonParser, msg)
45-
}
33+
) : InvalidNullException(processor, msg, null)

src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinFeature.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ enum class KotlinFeature(internal val enabledByDefault: Boolean) {
4343
* Enabling it protects against this but has significant performance impact.
4444
*/
4545
@Deprecated(
46-
level = DeprecationLevel.WARNING,
46+
level = DeprecationLevel.ERROR,
4747
message = "This option will be migrated to the new backend in 2.21.",
4848
replaceWith = ReplaceWith("NewStrictNullChecks")
4949
)

src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class KotlinModule private constructor(
4343
val nullToEmptyMap: Boolean = NullToEmptyMap.enabledByDefault,
4444
val nullIsSameAsDefault: Boolean = NullIsSameAsDefault.enabledByDefault,
4545
val singletonSupport: Boolean = SingletonSupport.enabledByDefault,
46+
@Suppress("DEPRECATION_ERROR")
4647
strictNullChecks: Boolean = StrictNullChecks.enabledByDefault,
4748
val kotlinPropertyNameAsImplicitName: Boolean = KotlinPropertyNameAsImplicitName.enabledByDefault,
4849
val useJavaDurationConversion: Boolean = UseJavaDurationConversion.enabledByDefault,
@@ -59,7 +60,7 @@ class KotlinModule private constructor(
5960
* Now that 2 is complete, deprecation is in progress for 3.
6061
*/
6162
@Deprecated(
62-
level = DeprecationLevel.WARNING,
63+
level = DeprecationLevel.ERROR,
6364
message = "This property is scheduled to be removed in 2.21 or later" +
6465
" in order to unify the use of KotlinFeature.",
6566
replaceWith = ReplaceWith("singletonSupport")
@@ -96,6 +97,7 @@ class KotlinModule private constructor(
9697
builder.isEnabled(NullToEmptyMap),
9798
builder.isEnabled(NullIsSameAsDefault),
9899
builder.isEnabled(SingletonSupport),
100+
@Suppress("DEPRECATION_ERROR")
99101
builder.isEnabled(StrictNullChecks),
100102
builder.isEnabled(KotlinPropertyNameAsImplicitName),
101103
builder.isEnabled(UseJavaDurationConversion),

0 commit comments

Comments
 (0)