Skip to content

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Dec 1, 2025

Description

Also prefer the external address over the NLLB address. If there's an external address, then it should be used instead of NLLB.

Add test cases for the konnectivity agent server config. Add support for IPv6 literals to k0snet.(Parse)HostPort.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

It's the only field that's required from the CfgVars struct. Makes
dependencies more obvious.

Signed-off-by: Tom Wieczorek <[email protected]>
The name KonnectivityServerHost is better reflecting what it is about.

Signed-off-by: Tom Wieczorek <[email protected]>
It was only used in two places, and can be replaced by a one-liner,
making it much clearer what is going on.

Signed-off-by: Tom Wieczorek <[email protected]>
Also prefer the external address over the NLLB address. If there's an
external address, then it should be used instead of NLLB.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review December 1, 2025 18:49
@twz123 twz123 requested review from a team as code owners December 1, 2025 18:49
@twz123 twz123 merged commit 684326c into k0sproject:main Dec 4, 2025
204 of 205 checks passed
@twz123 twz123 deleted the konnectivityagent-extaddress branch December 4, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants