Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional required host binaries #3841

Closed
twz123 opened this issue Dec 20, 2023 · 14 comments
Closed

Document additional required host binaries #3841

twz123 opened this issue Dec 20, 2023 · 14 comments
Labels
documentation Improvements or additions to documentation Stale

Comments

@twz123
Copy link
Member

twz123 commented Dec 20, 2023

K0s actually requires quite some host binaries to be present on worker machines. The docs should reflect that, and maybe some sysprobes should be added. See #3386 (comment) for details:

Looking at the repo https://github.com/kubernetes/mount-utils where all mount stuff is implemented, replacing (u)mount calls with syscalls is only small part of the problem. There's plenty of other exec calls it does to resize FS, systemd dependencies, FS initialization etc.. Replacing all these is really not feasible or possible. So replacing just mount doesn't really get us anywhere IMO. xref: kubernetes/mount-utils#13

@twz123 twz123 added the documentation Improvements or additions to documentation label Dec 20, 2023
@twz123 twz123 changed the title Document additional required binaries Document additional required host binaries Dec 20, 2023
@jnummelin
Copy link
Member

I think the challenge, especially relating to the mount-utils, is that not all the host bins are always needed. I think some of the exec calls are still due to in-tree volume providers and thus not always really needed. But in general I agree, we need to document these at least as soft dependencies.

@twz123
Copy link
Member Author

twz123 commented Dec 20, 2023

We already check quite some optional things in the sysprobes, e.g. some kernel config options. No need to have them to be hard failures, nevertheless good to know if they're missing.

@ncopa
Copy link
Collaborator

ncopa commented Dec 28, 2023

Isn't this fixed with 19c800d which both adds mount/umount to docs and a sysprobe?

@twz123
Copy link
Member Author

twz123 commented Jan 2, 2024

Isn't this fixed with 19c800d which both adds mount/umount to docs and a sysprobe?

This issue is about even more binaries, as Jussi pointed out in #3386 (comment).

Copy link
Contributor

github-actions bot commented Feb 1, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Feb 1, 2024
@twz123 twz123 removed the Stale label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

The issue is marked as stale since no activity has been recorded in 30 days

Copy link
Contributor

github-actions bot commented Apr 3, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Apr 3, 2024
@twz123 twz123 removed the Stale label Apr 4, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label May 4, 2024
@twz123 twz123 removed the Stale label May 6, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jun 5, 2024
@twz123 twz123 removed the Stale label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jul 6, 2024
@twz123 twz123 removed the Stale label Jul 7, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Aug 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
@twz123 twz123 reopened this Aug 21, 2024
@github-actions github-actions bot removed the Stale label Aug 21, 2024
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Sep 20, 2024
@twz123 twz123 removed the Stale label Sep 21, 2024
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Oct 21, 2024
@twz123 twz123 removed the Stale label Oct 23, 2024
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Nov 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Stale
Projects
None yet
Development

No branches or pull requests

4 participants