New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

junit reporter outputs invalid XML when test output contains invalid XML #1

Open

michaelglass opened this issue Apr 14, 2021 · 1 comment

michaelglass commented Apr 14, 2021

when we have terminal control characters, which are valid UTF-8 but not valid XML, in test output, then the junit output produced is invalid.

potential solutions:

fix upstream (see best practices for encoding control characters? snoyberg/xml#164)
filter out invalid characters in this library
filter out invalid characters in nri-prelude's junit reporter.

ghost commented Apr 19, 2021

All of these make sense to me, and I feel they're in order of descending "niceness".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment