From aa8d04c7234c72c770ddbca292f44c7eeaf9321e Mon Sep 17 00:00:00 2001 From: Chris McGee Date: Thu, 23 Feb 2017 12:56:33 -0500 Subject: [PATCH] remove __REDUX_DEV_UI__ as it's an extension now --- README.md | 5 +---- app/store/configureStore.development.js | 2 +- webpack.config.development.js | 1 - webpack.config.production.js | 1 - 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 23b342b1ca..cb56018ec3 100644 --- a/README.md +++ b/README.md @@ -51,11 +51,8 @@ The environment variable `DEBUG_ERROR` (boolean) controls whether or not errors The environment variable `REDUX_LOG` (boolean) controls whether or not the [redux logger middleware](https://github.com/fcomb/redux-logger/blob/master/README.md) is included. This middleware logs all redux actions in the Chrome developer console, including the (entire) previous and following app state trees. It is primarily useful when working on the UI of the app, and in fact can be quite performance-expensive (especially when uploading a device, due to the fact that every update to the progress bar constitutes an action), so it is not recommended to turn it on while working on device code. -#### `REDUX_DEV_UI` -The environment variable `REDUX_DEV_UI` (boolean) controls whether or not the [redux dev tools UI](https://github.com/gaearon/redux-devtools/blob/master/README.md) is included. The redux dev tools add a UI interface for exploring - and, to a limited extent, manipulating - app actions and state. Even when `REDUX_DEV_UI` is `true`, we have the dev tools hidden by default: the key combination `ctrl + h` will toggle their visibility. The key combination `ctrl + q` will rotate (clockwise) the location at which the dev tools are anchored; the default is for them to be anchored at the bottom of the app. Similarly to the redux logger middleware, the redux dev tools UI is also quite performance expensive and only recommended for use while working on UI code. - -`REDUX_LOG` and `REDUX_DEV_UI` are both turned on by default in `config/ui-debug.sh`. +`REDUX_LOG` is turned on by default in `config/ui-debug.sh`. ### Local Development w/o Debug Mode(s) diff --git a/app/store/configureStore.development.js b/app/store/configureStore.development.js index 3af7f67dd6..efc9578407 100644 --- a/app/store/configureStore.development.js +++ b/app/store/configureStore.development.js @@ -1,4 +1,4 @@ -/* global __REDUX_DEV_UI__, __REDUX_LOG__ */ +/* global __REDUX_LOG__ */ import { createStore, applyMiddleware, compose } from 'redux'; import thunk from 'redux-thunk'; diff --git a/webpack.config.development.js b/webpack.config.development.js index d5ec733fff..5126ae75d6 100755 --- a/webpack.config.development.js +++ b/webpack.config.development.js @@ -118,7 +118,6 @@ export default validate(merge(baseConfig, { 'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV) || '"development"', __DEBUG__: JSON.stringify(JSON.parse(process.env.DEBUG_ERROR || 'false')), __REDUX_LOG__: JSON.stringify(JSON.parse(process.env.REDUX_LOG || 'false')), - __REDUX_DEV_UI__: JSON.stringify(JSON.parse(process.env.REDUX_DEV_UI || 'false')), __TEST__: false, 'global.GENTLY': false, // http://github.com/visionmedia/superagent/wiki/SuperAgent-for-Webpack for platform-client }) diff --git a/webpack.config.production.js b/webpack.config.production.js index 85fe13117c..59f115275b 100755 --- a/webpack.config.production.js +++ b/webpack.config.production.js @@ -93,7 +93,6 @@ export default validate(merge(baseConfig, { 'process.env.NODE_ENV': JSON.stringify('production'), __DEBUG__: JSON.stringify(JSON.parse(process.env.DEBUG_ERROR || 'false')), __REDUX_LOG__: JSON.stringify(JSON.parse(process.env.REDUX_LOG || 'false')), - __REDUX_DEV_UI__: JSON.stringify(JSON.parse(process.env.REDUX_DEV_UI || 'false')), __TEST__: false, 'global.GENTLY': false, // http://github.com/visionmedia/superagent/wiki/SuperAgent-for-Webpack for platform-client }),