PRs to Gentoo

[candrews]

Can you please submit PRs to Gentoo? (I'm a Gentoo developer and will be happy to help you get them accepted) See https://wiki.gentoo.org/wiki/GitHub_Pull_Requests for reference.

I suggest you start with the OpenCL runtime. ROCT-Thunk-Interface, ROCR-Runtime, and ROCm-OpenCL-Runtime seem to be the base set. You'll need to change the names (as they don't comply with Gentoo standards right now) as well as some other things, please take a gander at https://devmanual.gentoo.org/ebuild-writing/file-format/index.html as a starting point. I think one PR adding all 3 packages (one commit per package - you're not allowed to modify multiple packages in one commit) would be great. I suggest adding one "final" version (ex "1.0") and one live ("9999") version per package (which you're already doing here in this overlay, so keep that up!).

I look forward to working with you and getting all of this into Gentoo for everyone to easily use! Thanks!

[justxi]

Hi,
I´m also interested to get this up.
The problem with final versions was in the past, that there are not always packaged versions of all components. We have to check this. A solution could be to create archives and upload them to a gentoo server(?). There are also some problems which should be solved, which I have documented in https://bugs.gentoo.org/650804.

I wil read your suggestions in the coming days.

[justxi]

Due to the fact, that ROCm 2.0 shall be release by end of year (ROCm/ROCm#609) we could focus on this version as a first release to the gentoo tree.

[candrews]

Due to the fact, that ROCm 2.0 shall be release by end of year (ROCm/ROCm#609) we could focus on this version as a first release to the gentoo tree.

That sounds good to me - you could start by creating the PR now with 9999 versions only so we can address ebuild format concerns (naming, style, etc).

[bluescarni]

That's great news, looking forward! I can help out with beta-testing if needed.

[justxi]

Due to the fact, that ROCm 2.0 shall be release by end of year (RadeonOpenCompute/ROCm#609) we could focus on this version as a first release to the gentoo tree.

That sounds good to me - you could start by creating the PR now with 9999 versions only so we can address ebuild format concerns (naming, style, etc).

It seems AMD is rolling out version 2.0.
So as suggested I am starting with the three base ebuilds. To get the naming etc. right, I will start with ROCT-Thunk-Interface, which I have to rename to ROCTThunkInterface-9999.ebuild, right?
For this package there is also a file release. So it should be easy to create a ROCTThunkInterface-2.0.ebuild.

Are the category names ok?

[candrews]

I will start with ROCT-Thunk-Interface, which I have to rename to ROCTThunkInterface-9999.ebuild, right?

Quoting from https://devmanual.gentoo.org/ebuild-writing/file-format/index.html

The name section should contain only lowercase non-accented letters, the digits 0-9, hyphens, underscores and plus characters. Uppercase characters are strongly discouraged, but technically valid.

Regarding category, I'm not sure if media-libs or dev-libs is better... The proprietary amd OpenCL driver is at dev-libs/amdgpu-pro-opencl, so that makes me think that dev-libs is probably better?

[justxi]

Intel and AMD sdk´s are in dev-util, but ocl-icd is also in dev-libs... (https://wiki.gentoo.org/wiki/OpenCL)

So I will move the ebuilds to dev-libs :).

[justxi]

I created two ebuilds for ROCTThunkInterface -> https://github.com/justxi/rocm/tree/master/dev-libs/ROCTThunkInterface.

Currently the problem is that the git-version (2.0.9999) creates a library with version 2.0.0. The ebuild which downloads the source package (tar.gz) creates a library with version 1.0.0. I think I should clarify this before creating a PR.

[justxi]

It seems that the version string is taken from the git repository otherwise a default string is used. I will submit a issue to the project (ROCm/ROCT-Thunk-Interface#26)

In the meantime I could create a patch to correct this.
What do you mean?

[justxi]

I created a patch to change the version (https://github.com/justxi/rocm/tree/master/dev-libs/ROCTThunkInterface).
I have to configure the repository as suggested and then I will submit my first PR.

[justxi]

Looks good to me. It´s always amazing what further improvements are possible compared to my approach. I will try the ebuilds on my system as soon as possible.

[justxi]

I think we should do the discussion in your thread and reference each new file here. I will keep this open until the basic files are in the official gentoo tree.

[justxi]

Work on installing ROCm according to FHS standard...
ROCm/ROCR-Runtime#51

[justxi]

State update: Current work focuses on getting an ebuild for "rocm-opencl-runtime" to work.