Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXTRA_NIX_ARGS are not universal (e.g.: --rebuild) #440

Open
srid opened this issue Mar 12, 2025 · 1 comment
Open

EXTRA_NIX_ARGS are not universal (e.g.: --rebuild) #440

srid opened this issue Mar 12, 2025 · 1 comment

Comments

@srid
Copy link
Member

srid commented Mar 12, 2025

Consider (after #439),

om ci run github:srid/haskell-template -- --refresh --override-input flake-parts github:hercules-ci/flake-parts --rebuild
...

❄️  nix eval --refresh --override-input flake-parts github:hercules-ci/flake-parts --rebuild --json 'github:srid/haskell-template#om' --quiet --quiet️
Error: Nix command error: Command error: Process exited unsuccessfully. exit_code=Some(1) stderr=error: unrecognised flag '--rebuild'
Try 'nix --help' for more information.

Here, we pass --rebuild, but that doesn't make sense in all Nix commands, such as nix eval. But omnix unconditionally passes them to all anyway.
@srid srid mentioned this issue Mar 12, 2025
Closed
@srid srid changed the title EXTRA_NIX_ARGS are not universal EXTRA_NIX_ARGS are not universal (e.g.: --rebuild) Mar 12, 2025
@srid srid mentioned this issue Mar 12, 2025
Merged
srid added a commit that referenced this issue Mar 12, 2025
@srid
Make om ci run . -- --rebuild work (#441)
efc02af 
Avoids #440 for `--rebuild` but does not totally settle #440, which will
require more careful work.

Also, 

- remove `--refresh` because that can be passed as `-- --refresh`.
- Remove the `-j auto` default.
@srid
Copy link
Member Author

srid commented Mar 12, 2025 •
edited
Loading

#441 is an attempt to address this, but I'm not really happy with it, so leaving this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srid