From 31240e7db525f4d5d64d2752eb58d640f0fc1fe7 Mon Sep 17 00:00:00 2001
From: Jurgen <jurgen.baas@outlook.com>
Date: Wed, 1 Jan 2025 21:56:34 +0100
Subject: [PATCH] fix: Removed a lingering on_research_finished event from the
 1.x version

---
 control.lua                      |  2 --
 events/researchFinishedEvent.lua | 33 --------------------------------
 2 files changed, 35 deletions(-)
 delete mode 100644 events/researchFinishedEvent.lua

diff --git a/control.lua b/control.lua
index 0a75324..9b56476 100644
--- a/control.lua
+++ b/control.lua
@@ -6,7 +6,6 @@ local util = require("util")
 local entity_built = require("events.entityBuilt")
 local place_tile_events = require("events.placeTileEvent")
 local tile_mined_event = require("events.tileMinedEvent")
-local research_finished_event = require("events.researchFinishedEvent")
 local entity_destroyed_event = require("events.entityDestroyedEvent")
 local surface_deleted_event = require("events.surfaceDeletedEvent")
 
@@ -71,7 +70,6 @@ script.on_event(defines.events.on_robot_built_entity, entity_built.event, entity
 script.on_event(defines.events.script_raised_built, entity_built.event, entity_built.filter)
 script.on_event(defines.events.script_raised_revive, entity_built.event, entity_built.filter)
 
-script.on_event(defines.events.on_research_finished, research_finished_event)
 script.on_event(defines.events.on_object_destroyed, entity_destroyed_event)
 script.on_event(defines.events.on_surface_deleted, surface_deleted_event)
 
diff --git a/events/researchFinishedEvent.lua b/events/researchFinishedEvent.lua
deleted file mode 100644
index 8337428..0000000
--- a/events/researchFinishedEvent.lua
+++ /dev/null
@@ -1,33 +0,0 @@
-local ore_manager = require("oreManager")
-
-local function get_keys(t)
-  local keys={}
-  for key, _ in pairs(t) do
-    table.insert(keys, key)
-  end
-  return keys
-end
-
-local function update_ores()
-  -- Get all the keys before iterating so you don't modify the key list while iterating.
-  local keys = get_keys(storage.resources)
-  
-  for _, key in ipairs(keys) do
-    local old_ore = storage.resources[key]
-    if old_ore.valid then
-
-      local new_ore = ore_manager.create_ore(old_ore.surface, old_ore.position)
-      new_ore.amount = old_ore.amount
-
-      ore_manager.delete_ore(old_ore)
-    end
-  end
-end
-
-local function research_finished_event(event)
-  if string.sub(event.research.name, 1, 20) == "mining-productivity-" then
-    update_ores()
-  end
-end
-
-return research_finished_event
\ No newline at end of file