Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error animation in code cell when error is triggered #1144

Open
andrewfulton9 opened this issue Dec 9, 2024 · 0 comments
Open

Show error animation in code cell when error is triggered #1144

andrewfulton9 opened this issue Dec 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@andrewfulton9
Copy link
Contributor

With JupyterLab #15344 the ability to add an error animation to a code call was added.

image

It should be relatively straight forward to allow the jupyter-ai completers to enable this functionality.

Problem

The jupyter-ai error reporting on inline completion differs from jupyterlab completer. Currently jupyterlab shows a flashing icon in the cell, while jupyter-ai has a notification warning

Proposed Solution

I propose allowing jupyter-ai to emit the error field when there is an error in the generation process. I am not sure if this should be in place of the error notification, or alongside of it. The benefit of keeping it alongside the current notification would be that the current notification gives more context.

Additional context

@andrewfulton9 andrewfulton9 added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant