Skip to content

Commit 127113a

Browse files
authored
Fix the metadata key (#36)
1 parent 0655f64 commit 127113a

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

examples/Layers.ipynb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
}
6060
}
6161
},
62-
"jupyterlab-deck": {
62+
"jupyterlab-slideshow": {
6363
"layer": "deck"
6464
},
6565
"tags": []
@@ -127,7 +127,7 @@
127127
}
128128
}
129129
},
130-
"jupyterlab-deck": {
130+
"jupyterlab-slideshow": {
131131
"layer": "fragment"
132132
},
133133
"tags": []
@@ -167,7 +167,7 @@
167167
}
168168
}
169169
},
170-
"jupyterlab-deck": {
170+
"jupyterlab-slideshow": {
171171
"layer": "slide"
172172
},
173173
"tags": []
@@ -208,7 +208,7 @@
208208
}
209209
}
210210
},
211-
"jupyterlab-deck": {
211+
"jupyterlab-slideshow": {
212212
"layer": "stack"
213213
},
214214
"tags": []

js/jupyterlab-slideshow/src/notebook/metadata.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export namespace DeckCellEditor {
170170
update() {
171171
this._activeMeta =
172172
(this._activeCell?.model
173-
? (getCellMetadata(this._activeCell?.model, META.deck) as ICellDeckMetadata)
173+
? (getCellMetadata(this._activeCell?.model, META.metadataKey) as ICellDeckMetadata)
174174
: null) || JSONExt.emptyObject;
175175
this.stateChanged.emit(void 0);
176176
}
@@ -258,9 +258,9 @@ export namespace DeckCellEditor {
258258

259259
protected _setDeckMetadata(newMeta: ICellDeckMetadata, cell: Cell<ICellModel>) {
260260
if (Object.keys(newMeta).length) {
261-
setCellMetadata(cell.model, META.deck, newMeta);
261+
setCellMetadata(cell.model, META.metadataKey, newMeta);
262262
} else {
263-
deleteCellMetadata(cell.model, META.deck);
263+
deleteCellMetadata(cell.model, META.metadataKey);
264264
}
265265
}
266266

js/jupyterlab-slideshow/src/notebook/presenter.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ export class NotebookPresenter implements IPresenter<NotebookPanel> {
202202
public getLayerScope(panel: NotebookPanel): string | null {
203203
let { activeCell } = panel.content;
204204
if (activeCell) {
205-
const meta = (getCellMetadata(activeCell.model, META.deck) || emptyObject) as any;
205+
const meta = (getCellMetadata(activeCell.model, META.metadataKey) || emptyObject) as any;
206206
return (meta[META.layer] || null) as TLayerScope;
207207
}
208208
return null;
@@ -214,15 +214,15 @@ export class NotebookPresenter implements IPresenter<NotebookPanel> {
214214
return;
215215
}
216216
let oldMeta =
217-
((getCellMetadata(activeCell.model, META.deck) || emptyObject) as Record<
217+
((getCellMetadata(activeCell.model, META.metadataKey) || emptyObject) as Record<
218218
string,
219219
any
220220
>) || null;
221221
if (layerScope == null) {
222222
if (oldMeta == null) {
223-
deleteCellMetadata(activeCell.model, META.deck);
223+
deleteCellMetadata(activeCell.model, META.metadataKey);
224224
} else {
225-
setCellMetadata(activeCell.model, META.deck, {
225+
setCellMetadata(activeCell.model, META.metadataKey, {
226226
...oldMeta,
227227
[META.layer]: layerScope,
228228
});
@@ -231,7 +231,7 @@ export class NotebookPresenter implements IPresenter<NotebookPanel> {
231231
if (oldMeta == null) {
232232
oldMeta = {};
233233
}
234-
setCellMetadata(activeCell.model, META.deck, {
234+
setCellMetadata(activeCell.model, META.metadataKey, {
235235
...oldMeta,
236236
[META.layer]: layerScope,
237237
});
@@ -636,7 +636,7 @@ export class NotebookPresenter implements IPresenter<NotebookPanel> {
636636

637637
/** Get layer metadata from `jupyterlab-slideshow` namespace */
638638
protected _getCellDeckMetadata(cell: ICellModel): ICellDeckMetadata {
639-
return (getCellMetadata(cell, META.deck) ||
639+
return (getCellMetadata(cell, META.metadataKey) ||
640640
emptyObject) as any as ICellDeckMetadata;
641641
}
642642

js/jupyterlab-slideshow/src/tokens.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ export namespace META {
230230
export const nullSelector = '';
231231
export const presentingCell = `body[data-jp-deck-mode='presenting'] &`;
232232
// deck
233-
export const deck = NS.split('/')[1];
233+
export const metadataKey = NS;
234234
export const layer = 'layer';
235235
}
236236

0 commit comments

Comments
 (0)