Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search and replace of a single entry more computationally efficient. #298

Open
ghost opened this issue Aug 28, 2020 · 0 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Aug 28, 2020

Describe the new feature being added

When searching for a value within the data editor, a list of matches is generated. When we replace one of these values (or make any other change to the editor while the search dialog is up), the list of matches is regenerated from scratch. We should instead just modify the original list of matches when needed.

How will this feature improve this extension

Currently, when we search our place a single entry the query is recomputed for the whole data set. This is computationally inefficient. It creates a noticeable lag when editing a large data set.

Describe alternatives you've considered

Another way to potentially increase the computational efficiency of search and replace is to only search over a part of the data set rather than the whole thing. This comes with some disadvantages and probably shouldn't be done as an alternative to the suggestions made here if it is done at all.

@ghost ghost added the enhancement New feature or request label Aug 28, 2020
@ghost ghost added this to the 1.0 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants