Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve option of LOAD api #88

Open
asha-ndf opened this issue Nov 14, 2020 · 2 comments
Open

Improve option of LOAD api #88

asha-ndf opened this issue Nov 14, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers mentored

Comments

@asha-ndf
Copy link

According to this doc(https://github.com/jupyter-xeus/xeus-sqlite/blob/master/docs/source/api.rst), LOADhas options [R/ RW].
However only [r / rw] can use. This different is just big letter or not.
To edit doc is one of the solution, but I think adding [R / RW] in https://github.com/jupyter-xeus/xeus-sqlite/blob/master/src/xeus_sqlite_interpreter.cpp is the best.

@marimeireles
Copy link
Member

Oh! Thanks for reporting this, never really tried, will let you know once I fix.

Or feel free to have a look at it yourself too... If you want, I think the problem is inside the void interpreter::load_db(const std::vector<std::string> tokenized_input) method. We have a few methods in the util.cpp file that can be useful, like to_upper and case_insentive_equals, not sure if the latter would have to be used.

Thanks for the issue! :)

@marimeireles marimeireles added bug Something isn't working good first issue Good for newcomers mentored labels Nov 16, 2020
@marimeireles
Copy link
Member

The docs were fixed, but this still needs attention.
Thanks again for opening the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers mentored
Projects
None yet
Development

No branches or pull requests

2 participants