Merged
Conversation
martinRenou
reviewed
Jun 19, 2025
Member
martinRenou
left a comment
There was a problem hiding this comment.
Looks great! Thanks a lot for adding documentation.
I've only found a small issue with the non-permanent tooltips, they seem to disappear whichever the location where you click, not only when you click on them:
Screencast.From.2025-06-19.13-42-17.mp4
Contributor
Author
I just tested this and it's the same in leaflet.js: https://jsfiddle.net/lopezvoliver/37r4xacw/8/ I will update the comment in the doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ipyleaflet.Tooltip in order to use leaflet tooltips.
The user can create a "standalone" tooltip at a given location, or bind a Tooltip widget to a Layer, as demonstrated below:
@martinRenou @arjxn-py or any other maintainer, please review =)