Remove pointless directional light distance slider

Author: Yahiewi

src/controls.ts

@@ -235,9 +235,8 @@ export class URDFControls extends GUI {
 
       // Initialize settings for each light type
       const directionalSettings = {
-        Distance: 10.9, // Initial distance from origin
-        Altitude: Math.PI / 4, // Initial altitude angle (radians)
-        Azimuth: Math.PI / 4, // Initial azimuth angle (radians)
+        Altitude: Math.PI / 4, // 45 degrees elevation
+        Azimuth: Math.PI / 4, // 45 degrees around vertical axis
         Color: [255, 255, 255],
         Intensity: 1.0,
         ShowHelper: false,
@@ -258,39 +257,28 @@ export class URDFControls extends GUI {
         SkyColor: [255, 255, 255],
         GroundColor: [38, 50, 56],
         Intensity: 1.0,
-        ShowHelper: false // Helper toggle moved here, off by default
+        ShowHelper: false
       };
 
       // Position limits and steps
-      const minPosition = -20;
-      const maxPosition = 20;
+      const minPosition = -50;
+      const maxPosition = 50;
       const positionStep = 0.1;
 
-      // Spherical coordinate limits and steps
-      const minDistance = 0.1;
-      const maxDistance = 30;
-      const distanceStep = 0.1;
+      // Spherical coordinate angle limits and steps
       const minAngle = -Math.PI;
       const maxAngle = Math.PI;
       const angleStep = 0.01;
 
       // Intensity limits and steps
       const minIntensity = 0;
-      const maxIntensity = 2;
-      const intensityStep = 0.05;
+      const maxIntensity = 10;
+      const intensityStep = 0.1;
 
       // Target controls for directional light
       const targetFolder = directionalFolder.addFolder('Target');
       this.controls.lights.directional = {
         position: {
-          // Using spherical coordinates instead of Cartesian
-          distance: directionalFolder.add(
-            directionalSettings,
-            'Distance',
-            minDistance,
-            maxDistance,
-            distanceStep
-          ),
           altitude: directionalFolder.add(
             directionalSettings,
             'Altitude',

src/layout.ts

@@ -225,34 +225,14 @@ export class URDFLayout extends PanelLayout {
     const directional = lightControl.directional;
 
     // Position controls using spherical coordinates
-    directional.position.distance.onChange((newDistance: number) => {
-      const altitude = directional.position.altitude.getValue();
-      const azimuth = directional.position.azimuth.getValue();
-      this._renderer.setDirectionalLightPositionSpherical(
-        newDistance,
-        altitude,
-        azimuth
-      );
-    });
-
     directional.position.altitude.onChange((newAltitude: number) => {
-      const distance = directional.position.distance.getValue();
       const azimuth = directional.position.azimuth.getValue();
-      this._renderer.setDirectionalLightPositionSpherical(
-        distance,
-        newAltitude,
-        azimuth
-      );
+      this._renderer.setDirectionalLightPositionSpherical(newAltitude, azimuth);
     });
 
     directional.position.azimuth.onChange((newAzimuth: number) => {
-      const distance = directional.position.distance.getValue();
       const altitude = directional.position.altitude.getValue();
-      this._renderer.setDirectionalLightPositionSpherical(
-        distance,
-        altitude,
-        newAzimuth
-      );
+      this._renderer.setDirectionalLightPositionSpherical(altitude, newAzimuth);
     });
 
     // Target position controls for directional light

src/renderer.ts

@@ -137,7 +137,7 @@ export class URDFRenderer extends THREE.WebGLRenderer {
     // Directional light
     const directionalLight = new THREE.DirectionalLight(0xfff2cc, 1.8);
     directionalLight.castShadow = true;
-    directionalLight.position.set(5, 12, 6);
+    directionalLight.position.set(3, 3, 3);
     directionalLight.shadow.camera.top = 5;
     directionalLight.shadow.camera.bottom = -5;
     directionalLight.shadow.camera.left = -5;
@@ -242,12 +242,10 @@ export class URDFRenderer extends THREE.WebGLRenderer {
   /**
    * Updates the position of the directional light using spherical coordinates
    *
-   * @param distance - Distance from target
    * @param altitude - Angle in radians from the horizontal plane (elevation)
    * @param azimuth - Angle in radians around the vertical axis
    */
   setDirectionalLightPositionSpherical(
-    distance: number,
     altitude: number,
     azimuth: number
   ): void {
@@ -256,6 +254,7 @@ export class URDFRenderer extends THREE.WebGLRenderer {
     ) as THREE.DirectionalLight;
 
     if (directionalLight) {
+      const distance = 3;
       const x = distance * Math.cos(altitude) * Math.cos(azimuth);
       const z = distance * Math.cos(altitude) * Math.sin(azimuth);
       const y = distance * Math.sin(altitude);