Skip to content

Commit 48f75a8

Browse files
committed
test(core): add more tests
1 parent 524bba5 commit 48f75a8

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

core/tests/check_label_name_test.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ TEST_P(CheckLabelNameTest, trailing_invalid_label_name) {
3030
TEST_P(CheckLabelNameTest, good_label_name) {
3131
EXPECT_TRUE(CheckLabelName("type"));
3232
}
33+
TEST_P(CheckLabelNameTest, numeric_label_name) {
34+
EXPECT_FALSE(CheckLabelName("2unlimited"));
35+
}
3336
TEST_P(CheckLabelNameTest, reserved_label_name) {
3437
EXPECT_FALSE(CheckLabelName("__some_reserved_label"));
3538
}

core/tests/check_metric_name_test.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ TEST(CheckMetricNameTest, empty_metric_name) {
1111
TEST(CheckMetricNameTest, good_metric_name) {
1212
EXPECT_TRUE(CheckMetricName("prometheus_notifications_total"));
1313
}
14+
TEST(CheckMetricNameTest, numeric_metric_name) {
15+
EXPECT_FALSE(CheckMetricName("2unlimited"));
16+
}
1417
TEST(CheckMetricNameTest, reserved_metric_name) {
1518
EXPECT_FALSE(CheckMetricName("__some_reserved_metric"));
1619
}

0 commit comments

Comments
 (0)