MDL-87600 gradereport_overview: Fix heading levels on the index page

Author: junpataleta

public/grade/report/overview/index.php

@@ -193,7 +193,7 @@
                 exit;
             }
             if ($report->fill_table(true, true)) {
-                echo html_writer::tag('h3', get_string('coursesiamtaking', 'grades'));
+                echo $OUTPUT->heading(get_string('coursesiamtaking', 'grades'));
                 echo '<br />' . $report->print_table(true);
             }
         } else { // We have a course context. We must be navigating from the gradebook.
@@ -223,7 +223,7 @@
             echo $OUTPUT->footer();
             exit;
         }
-        echo html_writer::tag('h3', get_string('coursesiamteaching', 'grades'));
+        echo $OUTPUT->heading(get_string('coursesiamteaching', 'grades'));
         $report->print_teacher_table();
     }
 

public/grade/report/overview/tests/behat/view_grades.feature

@@ -0,0 +1,30 @@
+@gradereport @gradereport_overview
+Feature: Grade overview report can be viewed
+  In order to see the courses I am enrolled in
+  As a user
+  I should be able to access the grade overview report's index page
+
+  Background:
+    Given the following "courses" exist:
+      | fullname        | shortname |
+      | Awesome course  | C1        |
+    And the following "users" exist:
+      | username | firstname | lastname | email           |
+      | teacher1 | Teacher   | 1        | t1@example.com  |
+      | student1 | Student   | 1        | s1@example.com  |
+    And the following "course enrolments" exist:
+      | user     | course | role            |
+      | teacher1 | C1     | editingteacher  |
+      | student1 | C1     | student         |
+
+  @javascript @accessibility
+  Scenario Outline: The grade overview report index page should be accessible
+    Given I am logged in as "<user>"
+    When I follow "Grades" in the user menu
+    Then "<headingname>" "heading" should exist
+    And the page should meet accessibility standards with "best-practice" extra tests
+
+    Examples:
+      | user      | headingname           |
+      | student1  | Courses I am taking   |
+      | teacher1  | Courses I am teaching |