Skip to content

Commit 011d7f4

Browse files
committed
Apply review
1 parent 153a08e commit 011d7f4

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

junit-platform-commons/src/main/java/org/junit/platform/commons/support/conversion/ConversionSupport.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
package org.junit.platform.commons.support.conversion;
1212

13+
import static org.apiguardian.api.API.Status.DEPRECATED;
1314
import static org.apiguardian.api.API.Status.EXPERIMENTAL;
1415

1516
import java.util.ServiceLoader;
@@ -52,6 +53,7 @@ private ConversionSupport() {
5253
*/
5354
@SuppressWarnings("unchecked")
5455
@Deprecated
56+
@API(status = DEPRECATED, since = "5.12")
5557
public static <T> T convert(String source, Class<T> targetType, ClassLoader classLoader) {
5658
return (T) DefaultConversionService.INSTANCE.convert(source, targetType, getClassLoader(classLoader));
5759
}
@@ -84,7 +86,7 @@ public static <T> T convert(Object source, Class<T> targetType, ClassLoader clas
8486
.filter(candidate -> candidate.canConvert(source, targetType, classLoader)) //
8587
.findFirst() //
8688
.map(candidate -> candidate.convert(source, targetType, classLoaderToUse)) //
87-
.orElseThrow(() -> new ConversionException("No built-in converter for source type "
89+
.orElseThrow(() -> new ConversionException("No registered or built-in converter for source type "
8890
+ source.getClass().getTypeName() + " and target type " + targetType.getTypeName()));
8991
}
9092

junit-platform-commons/src/module/org.junit.platform.commons/module-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,6 @@
5454
org.junit.platform.suite.engine,
5555
org.junit.platform.testkit,
5656
org.junit.vintage.engine;
57+
uses org.junit.platform.commons.support.conversion.ConversionService;
5758
uses org.junit.platform.commons.support.scanning.ClasspathScanner;
5859
}

platform-tooling-support-tests/projects/jar-describe-module/junit-platform-commons.expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ requires java.base mandated
99
requires java.logging
1010
requires java.management
1111
requires org.apiguardian.api static transitive
12+
uses org.junit.platform.commons.support.conversion.ConversionService
1213
uses org.junit.platform.commons.support.scanning.ClasspathScanner
1314
qualified exports org.junit.platform.commons.logging to org.junit.jupiter.api org.junit.jupiter.engine org.junit.jupiter.migrationsupport org.junit.jupiter.params org.junit.platform.console org.junit.platform.engine org.junit.platform.launcher org.junit.platform.reporting org.junit.platform.runner org.junit.platform.suite.api org.junit.platform.suite.engine org.junit.platform.testkit org.junit.vintage.engine
1415
qualified exports org.junit.platform.commons.util to org.junit.jupiter.api org.junit.jupiter.engine org.junit.jupiter.migrationsupport org.junit.jupiter.params org.junit.platform.console org.junit.platform.engine org.junit.platform.jfr org.junit.platform.launcher org.junit.platform.reporting org.junit.platform.runner org.junit.platform.suite.api org.junit.platform.suite.commons org.junit.platform.suite.engine org.junit.platform.testkit org.junit.vintage.engine

0 commit comments

Comments
 (0)