Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: check file change date/hash and only reload if changed #13

Open
laundmo opened this issue Jun 1, 2021 · 2 comments · May be fixed by #28
Open

improvement: check file change date/hash and only reload if changed #13

laundmo opened this issue Jun 1, 2021 · 2 comments · May be fixed by #28

Comments

@laundmo
Copy link
Contributor

laundmo commented Jun 1, 2021 •
edited
Loading

stat the file, or compare to previous hash, to only reload the code when changes occured.
@laundmo laundmo changed the title improvment: check file change date/hash and only reload if changed improvement: check file change date/hash and only reload if changed Jun 4, 2021
@s39674
Copy link

s39674 commented May 20, 2022

Hi @laundmo,
I don't see why would you use reloading for that. You could just use a timer that every so often check the file's hash and if that changed it execute the code.

@laundmo
Copy link
Contributor Author

laundmo commented May 20, 2022

to clarify: i meant to only reload if the file has changed, not to run the code on a timer.

this is so that reloading has the performance impact of just a single stat, instead of "reloading" even if the file has no changes.

@nneskildsf nneskildsf linked a pull request Dec 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve reloading nneskildsf/reloading
2 participants
@laundmo @s39674