You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think you are missing some values in your is_diphthong and is_valid_consonant_cluster to give better results. Edit: I just realized this is for ancient Greek and my use case is modern Greek, so I am not sure my changes will apply.
I also wrote a bad test to make sure I follow the consensus on syllabifying.
Let me know if you want a pull request, or I can just paste them here.
The text was updated successfully, but these errors were encountered:
I think you are missing some values in your
is_diphthong
andis_valid_consonant_cluster
to give better results.Edit: I just realized this is for ancient Greek and my use case is modern Greek, so I am not sure my changes will apply.
I also wrote a bad test to make sure I follow the consensus on syllabifying.
Let me know if you want a pull request, or I can just paste them here.
The text was updated successfully, but these errors were encountered: