Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one CanMap can be saved to flash #31

Open
jsphuebner opened this issue Feb 4, 2025 · 2 comments
Open

Only one CanMap can be saved to flash #31

jsphuebner opened this issue Feb 4, 2025 · 2 comments

Comments

@jsphuebner
Copy link
Owner

Currently only one flash location can be specified for saving CAN mappings to. In addition, both CanSdo and TerminalCommands only allow saving one map as well.

@zacck
Copy link

zacck commented Mar 1, 2025

@jsphuebner I would like to see if I can use this as an inroad to contributing to open inverter firmware, could you describe an ideal solution?

@jsphuebner
Copy link
Owner Author

There is the simple method of modifying CanMap::GetFlashAddress() to return CAN1_FLASH if the device in use is CAN1 and otherwise CAN2_FLASH.

The other method would be to refactor flash saving altogether. It bugs me that there is a hardware dependency in the otherwise hardware independent CanMap class.

So there could be a Flash class that somehow manages flash pages in a backward compatible manner. An instance of that class can then be passed to all modules (CanMap and Params basically) that save things to flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants