Skip to content

Commit 42b5ede

Browse files
author
Heinrich Filter
committed
Create interface with default implementation for config
1 parent b5c12a7 commit 42b5ede

File tree

5 files changed

+18
-10
lines changed

5 files changed

+18
-10
lines changed

src/main/java/io/github/jsonSnapshot/Config.java

-5
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package io.github.jsonSnapshot;
2+
3+
import lombok.Getter;
4+
5+
public class DefaultConfig implements SnapshotConfig {
6+
@Getter
7+
private String filePath = "src/test/java/";
8+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package io.github.jsonSnapshot;
2+
3+
public interface SnapshotConfig {
4+
String getFilePath();
5+
}

src/main/java/io/github/jsonSnapshot/SnapshotMatcher.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ public class SnapshotMatcher {
3232
private static List<Snapshot> calledSnapshots = new ArrayList<>();
3333

3434
public static void start() {
35-
start(new Config());
35+
start(new DefaultConfig());
3636
}
3737

38-
public static void start(Config config) {
38+
public static void start(SnapshotConfig config) {
3939
try {
4040
StackTraceElement stackElement = findStackElement();
4141
clazz = Class.forName(stackElement.getClassName());
42-
snapshotFile = new SnapshotFile(config.filePath,stackElement.getClassName().replaceAll("\\.", "/") + ".snap");
42+
snapshotFile = new SnapshotFile(config.getFilePath(), stackElement.getClassName().replaceAll("\\.", "/") + ".snap");
4343
} catch (ClassNotFoundException | IOException e) {
4444
throw new SnapshotMatchException(e.getMessage());
4545
}

src/test/java/io/github/jsonSnapshot/SnapshotTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
@RunWith(MockitoJUnitRunner.class)
1919
public class SnapshotTest {
2020

21-
private static final Config DEFAULT_CONFIG = new Config();
21+
private static final SnapshotConfig DEFAULT_CONFIG = new DefaultConfig();
2222
private static final String FILE_PATH = "src/test/java/anyFilePath";
2323
private static final String SNAPSHOT_NAME = "java.lang.String.toString=";
2424
private static final String SNAPSHOT = "java.lang.String.toString=[\n \"anyObject\"\n]";
@@ -30,7 +30,7 @@ public class SnapshotTest {
3030

3131
@Before
3232
public void setUp() throws NoSuchMethodException, IOException {
33-
snapshotFile = new SnapshotFile(DEFAULT_CONFIG.filePath,"anyFilePath");
33+
snapshotFile = new SnapshotFile(DEFAULT_CONFIG.getFilePath(), "anyFilePath");
3434
snapshot = new Snapshot(snapshotFile, String.class,
3535
String.class.getDeclaredMethod("toString"), "anyObject");
3636
}

0 commit comments

Comments
 (0)