Skip to content

Approval requirements on PRs #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregsdennis opened this issue Jul 14, 2022 · 3 comments
Closed

Approval requirements on PRs #1258

gregsdennis opened this issue Jul 14, 2022 · 3 comments

Comments

@gregsdennis
Copy link
Member

Should we enable approval requirements for PRs?

image

I think that these two options would be a good thing. Admins on the repo can still merge without these requirements being met (there's also a setting to have this apply to admins).

There are a few other options as well, but these two in particular stand out to me.

@gregsdennis
Copy link
Member Author

gregsdennis commented Jul 18, 2022

In the 2022-07-18 OCWM call, we decided that adding the requirement of an approval is good. We'll want to apply this to all the repos.

@gregsdennis
Copy link
Member Author

gregsdennis commented Jul 18, 2022

I'm just going to create the rule for the current default branch. Some repos are still on master; I won't be changing these to main.

Further options
image

@gregsdennis
Copy link
Member Author

Closing for now since we've enabled approval where applicable. If we need to discuss some of these other features, a new issue or reopening this one is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant