Merge pull request #368 from alextomaili/fix-memory-allocation-overhead

taowen · web-flow · commit 94869abf4301 · 2019-06-22T00:11:00.000+08:00
allocate string for error description only if it really required
diff --git a/reflect_struct_decoder.go b/reflect_struct_decoder.go
@@ -530,8 +530,8 @@ func (decoder *generalStructDecoder) decodeOneField(ptr unsafe.Pointer, iter *It
 		}
 	}
 	if fieldDecoder == nil {
-		msg := "found unknown field: " + field
 		if decoder.disallowUnknownFields {
+			msg := "found unknown field: " + field
 			iter.ReportError("ReadObject", msg)
 		}
 		c := iter.nextToken()

Original file line number	Diff line number	Diff line change
`@@ -530,8 +530,8 @@ func (decoder generalStructDecoder) decodeOneField(ptr unsafe.Pointer, iter It`
`530`	`530`	`}`
`531`	`531`	`}`
`532`	`532`	`if fieldDecoder == nil {`
`533`		`- msg := "found unknown field: " + field`
`534`	`533`	`if decoder.disallowUnknownFields {`
	`534`	`+ msg := "found unknown field: " + field`
`535`	`535`	`iter.ReportError("ReadObject", msg)`
`536`	`536`	`}`
`537`	`537`	`c := iter.nextToken()`