-
-
Notifications
You must be signed in to change notification settings - Fork 49
feat: add types #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
feat: add types #69
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@jonchurch @bjohansebas @clicktodev Could you please take a look at this PR when you get a chance? It’s part of the TypeScript WG initiative, and since we’re members, your input would be valuable. |
bjohansebas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think this should be targeted at version 2, since that’s the one being depended on. These changes can be backported to version 3
|
@bjohansebas I recommend merging this into |
|
the advantage of releasing this as a new major release is that people will be more likely to read the patch notes since it's a major release and they will discover that they shouldn't install third party types anymore. |
This PR adds type definitions to finalhandler. It includes the following changes:
type,mainandtypesfield topackage.json@tsconfig/node18from https://github.com/tsconfig/bases@arethetypeswrong/cliandexpect-typeand run them in the CI PipelineRef: expressjs/typescript-wg#1
cc @RobinTail