Skip to content

Conversation

@Phillip9587
Copy link
Contributor

This PR adds type definitions to finalhandler. It includes the following changes:

Ref: expressjs/typescript-wg#1

cc @RobinTail

@socket-security
Copy link

socket-security bot commented Aug 14, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​tsconfig/​node18@​18.2.41001007179100
Addedexpect-type@​1.2.210010010080100
Added@​types/​node@​18.19.1301001008195100
Added@​arethetypeswrong/​cli@​0.18.210010010086100
Addedtypescript@​5.9.3100100909990

View full report

@Phillip9587 Phillip9587 requested a review from jonchurch October 27, 2025 20:41
@Phillip9587
Copy link
Contributor Author

@jonchurch @bjohansebas @clicktodev Could you please take a look at this PR when you get a chance? It’s part of the TypeScript WG initiative, and since we’re members, your input would be valuable.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think this should be targeted at version 2, since that’s the one being depended on. These changes can be backported to version 3

@Phillip9587
Copy link
Contributor Author

@bjohansebas I recommend merging this into v3. If it turns out to be necessary, we can backport it to v2 afterwards.

@clicktodev
Copy link

the advantage of releasing this as a new major release is that people will be more likely to read the patch notes since it's a major release and they will discover that they shouldn't install third party types anymore.
the only problem with releasing the types in the existing release is that it may conflict with third party types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants