Add test for when the maven checkstyle plugin is not configured but syncing is enabled

Author: nrayburn-tech

src/test/java/org/infernus/idea/checkstyle/maven/MavenCheckstyleConfiguratorTest.java

@@ -17,8 +17,6 @@
 import org.infernus.idea.checkstyle.model.ScanScope;
 import org.jetbrains.idea.maven.utils.MavenUtil;
 import org.junit.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public class MavenCheckstyleConfiguratorTest extends MavenMultiVersionImportingTestCase {
 
@@ -27,9 +25,7 @@ public class MavenCheckstyleConfiguratorTest extends MavenMultiVersionImportingT
         <artifactId>test</artifactId>
         <version>1</version>
         <name>test</name>
-        """;
-    private static final Logger log = LoggerFactory.getLogger(
-        MavenCheckstyleConfiguratorTest.class);
+        """.stripIndent();
 
     @Test
     public void afterImport_importSettingsFromMavenIsDisabled_doesNothing() throws Exception {
@@ -318,8 +314,8 @@ public void updatePluginConfigLocationsFromMavenPlugin_configLocationExistsAndMa
         final var configurationLocationFactory = getProject().getService(
             ConfigurationLocationFactory.class);
 
-      final var configPath = Files.writeString(
-          getProjectRoot().toNioPath().resolve("checkstyle.xml"), "<config></config>");
+        final var configPath = Files.writeString(
+            getProjectRoot().toNioPath().resolve("checkstyle.xml"), "<config></config>");
         final var mavenConfigLocation = configurationLocationFactory.create(getProject(),
             "maven-config-location", ConfigurationType.PROJECT_RELATIVE, "checkstyle-existing.xml",
             "Maven Config Location", NamedScopeHelper.getDefaultScope(getProject()));
@@ -361,8 +357,8 @@ public void updatePluginConfigLocationsFromMavenPlugin_mavenConfigDoesNotAlready
         final var pluginConfigurationManager = getProject().getService(
             PluginConfigurationManager.class);
 
-      final var configPath = Files.writeString(
-          getProjectRoot().toNioPath().resolve("checkstyle.xml"), "<config></config>");
+        final var configPath = Files.writeString(
+            getProjectRoot().toNioPath().resolve("checkstyle.xml"), "<config></config>");
         final var updatedConfigurationBuilder = PluginConfigurationBuilder.from(
             pluginConfigurationManager.getCurrent());
         updatedConfigurationBuilder.withImportSettingsFromMaven(true).withLocations(new TreeSet<>())
@@ -457,4 +453,36 @@ public void updatePluginScanScopeFromMavenPlugin_includeSettingsExistsAndScanSco
 
         assertEquals(ScanScope.JavaOnly, pluginConfigurationManager.getCurrent().getScanScope());
     }
+
+    @Test
+    public void afterImport_mavenCheckstylePluginNotConfiguredAndSyncEnabled_doesNotThrow()
+        throws Exception {
+        final var pluginConfigurationManager = getProject().getService(
+            PluginConfigurationManager.class);
+
+        final var updatedConfigurationBuilder = PluginConfigurationBuilder.from(
+            pluginConfigurationManager.getCurrent());
+        updatedConfigurationBuilder.withImportSettingsFromMaven(true);
+        pluginConfigurationManager.setCurrent(updatedConfigurationBuilder.build(), true);
+
+        createProjectPom(PROJECT_INFO);
+
+        assertDoesNotThrow(() -> BuildersKt.runBlocking(EmptyCoroutineContext.INSTANCE,
+            (scope, continuation) -> importProjectAsync(continuation)));
+    }
+
+    // TODO: Replace this when migrating to JUnit 5.
+    private void assertDoesNotThrow(Executable executable) {
+        try {
+            executable.execute();
+        } catch (Exception e) {
+            fail("Unexpected exception thrown: " + e.getClass().getName() + ": " + e.getMessage());
+        }
+    }
+
+    @FunctionalInterface
+    interface Executable {
+
+        void execute() throws Exception;
+    }
 }