Skip to content

Commit 6e7dd28

Browse files
committed
fix!: remove deprecated methods
1 parent b4abceb commit 6e7dd28

File tree

10 files changed

+23
-321
lines changed

10 files changed

+23
-321
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,17 @@
11
name: test
22
on: [push, pull_request]
3-
env:
4-
CI: true
53
jobs:
64
test:
75
name: "Test on Node.js ${{ matrix.node-version }}"
86
runs-on: ubuntu-latest
97
strategy:
108
matrix:
11-
node-version: [ 12, 14, 16 ]
9+
node-version: [ 18 ]
1210
steps:
1311
- name: checkout
14-
uses: actions/checkout@v2
12+
uses: actions/checkout@v3
1513
- name: setup Node.js ${{ matrix.node-version }}
16-
uses: actions/setup-node@v1
14+
uses: actions/setup-node@v3
1715
with:
1816
node-version: ${{ matrix.node-version }}
1917
- name: Install

lerna.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@
55
"packages/@jser/*"
66
],
77
"version": "1.2.1",
8-
"npmClient": "yarn",
9-
"useWorkspaces": true
8+
"npmClient": "yarn"
109
}

packages/@jser/data-fetcher/src/data-fetcher.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import fetch from "cross-fetch";
21
export interface JserItem {
32
title: string;
43
url: string;

packages/@jser/data-fetcher/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"moduleResolution": "node",
66
"newLine": "LF",
77
"outDir": "./lib/",
8-
"target": "es5",
8+
"target": "ES2020",
99
"sourceMap": true,
1010
"declaration": true,
1111
"jsx": "preserve",
@@ -32,4 +32,4 @@
3232
".git",
3333
"node_modules"
3434
]
35-
}
35+
}

packages/@jser/post-parser/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"moduleResolution": "node",
66
"newLine": "LF",
77
"outDir": "./lib/",
8-
"target": "es5",
8+
"target": "ES2020",
99
"sourceMap": true,
1010
"declaration": true,
1111
"jsx": "preserve",
@@ -32,4 +32,4 @@
3232
".git",
3333
"node_modules"
3434
]
35-
}
35+
}

packages/@jser/stat/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@
4949
"typescript": "^5.1.3"
5050
},
5151
"dependencies": {
52-
"binarysearch": "^1.0.0",
53-
"lodash.sortby": "^4.7.0"
52+
"binarysearch": "^1.0.0"
5453
},
5554
"prettier": {
5655
"printWidth": 120,

packages/@jser/stat/src/JSerStat.ts

Lines changed: 2 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
// LICENSE : MIT
22
"use strict";
3-
import sortBy from "lodash.sortby";
43
import { JSerItem } from "./models/JSerItem";
54
import { JSerPost } from "./models/JSerPost";
65
import { JSerWeek } from "./models/JSerWeek";
76
import { AlgoItem } from "./algo/AlgoItem";
8-
// import AlgoPost from "./algo/AlgoPost";
9-
10-
import NaturalSearcher from "./natural/NaturalSearcher";
11-
127
function sortByDate(items: JSerItem[]) {
13-
return sortBy(items, (item: JSerItem) => {
14-
return item.date;
8+
return items.slice().sort(function (a, b) {
9+
return new Date(a.date).getTime() - new Date(b.date).getTime();
1510
});
1611
}
1712

@@ -26,8 +21,6 @@ export class JSerStat {
2621
posts: JSerPost[];
2722
private _weeks: JSerWeek[];
2823
private _algoItem: AlgoItem;
29-
// private _algoPost: AlgoPost;
30-
private naturalSearch: any;
3124

3225
constructor(rawItems: any[], rawPosts: any[]) {
3326
this._rawItems = rawItems;
@@ -59,15 +52,6 @@ export class JSerStat {
5952
* @private
6053
**/
6154
this._algoItem = new AlgoItem(this.items);
62-
/**
63-
* @type {AlgoPost}
64-
* @private
65-
*/
66-
// this._algoPost = new AlgoPost(this.posts);
67-
/**
68-
* @type {NaturalSearcher}
69-
*/
70-
this.naturalSearch = null;
7155
}
7256

7357
/**
@@ -206,17 +190,4 @@ export class JSerStat {
206190
return item.url === URL;
207191
});
208192
}
209-
210-
/**
211-
* `item` と関連するJSerItemの配列を返す
212-
* @param {JSerItem} item
213-
* @param {number} limit
214-
* @returns {JSerItem[]}
215-
*/
216-
findRelatedItems(item: JSerItem, limit = 10) {
217-
if (this.naturalSearch == null) {
218-
this.naturalSearch = new NaturalSearcher(this.items);
219-
}
220-
return this.naturalSearch.findRelatedItems(item, limit);
221-
}
222193
}

packages/@jser/stat/test/JSerStat-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ describe("@jser/stat", function () {
199199
assert(expectedItem.isEqualItem(item));
200200
});
201201
});
202-
describe("#findRelatedItems", function () {
202+
describe.skip("#findRelatedItems", function () {
203203
it("should return JSerItem[] related item", function () {
204204
var posts = [
205205
{

packages/@jser/stat/tsconfig.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
"moduleResolution": "node",
66
"newLine": "LF",
77
"outDir": "./lib/",
8-
"target": "es5",
8+
"target": "ES2020",
99
"sourceMap": true,
1010
"declaration": true,
1111
"jsx": "preserve",
1212
"lib": [
13-
"es2017",
13+
"esnext",
1414
"dom"
1515
],
1616
/* Strict Type-Checking Options */
@@ -32,4 +32,4 @@
3232
".git",
3333
"node_modules"
3434
]
35-
}
35+
}

0 commit comments

Comments
 (0)