Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe adoption expiration #33

Closed
MartinKolarik opened this issue Oct 12, 2024 · 1 comment · Fixed by #36
Closed

Probe adoption expiration #33

MartinKolarik opened this issue Oct 12, 2024 · 1 comment · Fixed by #36
Assignees

Comments

@MartinKolarik
Copy link
Member

Probes are supposed to stay adopted for up to 30 days of being offline. We track the sync dates, but I don't think there's anything that would delete them yet. We should (assuming the probe's last sync date is 2024-10-12):

  • on 2024-10-14 send a notification to the user "Your probe went offline", "Your probe [name (IP)] has been offline for more than 24 hours. If it does not come back online before Nov 12, 2024, it will be removed from your account."
  • on 2024-10-12 remove the probe and send another notification "Your probe has been deleted" "Your probe [...] has been deleted from your account due to being offline for more than 30 days. You can adopt it again when it is back online."

We can later improve the notifications speed and add emails in jsdelivr/globalping-dash#27.

@MartinKolarik
Copy link
Member Author

I found we actually do have the expiration logic, so we just need the notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants