Skip to content

Commit 1fcf84b

Browse files
committed
fix(signing): inject keystore via local.properties in CI
1 parent 2b892ab commit 1fcf84b

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/tag-and-release.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,20 @@ jobs:
6767
TOKEN: ${{ secrets.GITHUB_TOKEN }}
6868
run: ./gradlew --no-daemon test
6969

70-
- name: Decode keystore
71-
run: echo "${{ secrets.SIGNING_KEYSTORE }}" | base64 -d > app/barberfish.keystore
70+
- name: Inject signing config
71+
env:
72+
SIGNING_KEYSTORE: ${{ secrets.SIGNING_KEYSTORE }}
73+
run: |
74+
echo "$SIGNING_KEYSTORE" | base64 -d > app/barberfish.keystore
75+
echo "signing.store.file=barberfish.keystore" >> local.properties
76+
echo "signing.store.password=${{ secrets.SIGNING_STORE_PASSWORD }}" >> local.properties
77+
echo "signing.key.alias=${{ secrets.SIGNING_KEY_ALIAS }}" >> local.properties
78+
echo "signing.key.password=${{ secrets.SIGNING_KEY_PASSWORD }}" >> local.properties
7279
7380
- name: Assemble release APK
7481
env:
7582
USERNAME: ${{ github.actor }}
7683
TOKEN: ${{ secrets.GITHUB_TOKEN }}
77-
SIGNING_KEYSTORE_PATH: app/barberfish.keystore
78-
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_STORE_PASSWORD }}
79-
SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }}
80-
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
8184
run: ./gradlew --no-daemon assembleRelease
8285

8386
- name: Generate manifest

app/build.gradle.kts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,12 @@ android {
2525

2626
signingConfigs {
2727
create("release") {
28-
val storePath = System.getenv("SIGNING_KEYSTORE_PATH") ?: localProperties["signing.store.file"] as? String
29-
val storePass = System.getenv("SIGNING_STORE_PASSWORD") ?: localProperties["signing.store.password"] as? String
30-
val alias = System.getenv("SIGNING_KEY_ALIAS") ?: localProperties["signing.key.alias"] as? String
31-
val keyPass = System.getenv("SIGNING_KEY_PASSWORD") ?: localProperties["signing.key.password"] as? String
28+
val storePath = localProperties["signing.store.file"] as? String
3229
if (storePath != null) {
3330
storeFile = file(storePath)
34-
storePassword = storePass
35-
keyAlias = alias
36-
keyPassword = keyPass
31+
storePassword = localProperties["signing.store.password"] as? String
32+
keyAlias = localProperties["signing.key.alias"] as? String
33+
keyPassword = localProperties["signing.key.password"] as? String
3734
}
3835
}
3936
}

0 commit comments

Comments
 (0)