Skip to content

Commit 10381a2

Browse files
authored
Find&Replace coreclr/src -> coreclr (dotnet#45761)
1 parent 18d1527 commit 10381a2

File tree

119 files changed

+195
-195
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+195
-195
lines changed

.gitattributes

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@
6767
*.h linguist-language=C
6868

6969
# CLR specific
70-
src/coreclr/src/pal/tests/palsuite/paltestlist.txt text eol=lf
71-
src/coreclr/src/pal/tests/palsuite/paltestlist_to_be_reviewed.txt text eol=lf
70+
src/coreclr/pal/tests/palsuite/paltestlist.txt text eol=lf
71+
src/coreclr/pal/tests/palsuite/paltestlist_to_be_reviewed.txt text eol=lf
7272
src/tests/JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regexdna-input25.txt text eol=lf
7373
src/tests/JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regexdna-input25000.txt text eol=lf
7474
src/tests/JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/revcomp-input25.txt text eol=lf

.github/CODEOWNERS

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
# CoreCLR Code Owners
1111

12-
/src/coreclr/src/inc/corinfo.h @dotnet/jit-contrib
13-
/src/coreclr/src/inc/corjit.h @dotnet/jit-contrib
14-
/src/coreclr/src/jit/ @dotnet/jit-contrib
12+
/src/coreclr/inc/corinfo.h @dotnet/jit-contrib
13+
/src/coreclr/inc/corjit.h @dotnet/jit-contrib
14+
/src/coreclr/jit/ @dotnet/jit-contrib
1515

1616
# Mono Code Owners
1717

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ The following file header is the used for .NET Core. Please use it for new files
107107
// The .NET Foundation licenses this file to you under the MIT license.
108108
```
109109

110-
- See [class.cpp](./src/coreclr/src/vm/class.cpp) for an example of the header in a C++ file.
110+
- See [class.cpp](./src/coreclr/vm/class.cpp) for an example of the header in a C++ file.
111111
- See [List.cs](./src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs) for an example of the header in a C# file.
112112

113113
## PR - CI Process

docs/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ Other Information
7171
- [.NET Filename Encyclopedia](project/dotnet-filenames.md)
7272
- [Porting to .NET Core](https://docs.microsoft.com/en-us/dotnet/standard/analyzers/portability-analyzer)
7373
- [.NET Standards (Ecma)](project/dotnet-standards.md)
74-
- [CLR Configuration Knobs](../src/coreclr/src/inc/clrconfigvalues.h)
74+
- [CLR Configuration Knobs](../src/coreclr/inc/clrconfigvalues.h)
7575
- [CLR overview](https://docs.microsoft.com/dotnet/standard/clr)
7676
- [Wikipedia Entry for the CLR](https://en.wikipedia.org/wiki/Common_Language_Runtime)

docs/coding-guidelines/EventLogging.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ Event Logging is a mechanism by which CoreClr can provide a variety of informati
66

77
# Adding Events to the Runtime
88

9-
- Edit the [Event manifest](../../src/coreclr/src/vm/ClrEtwAll.man) to add a new event. For guidelines on adding new events, take a look at the existing events in the manifest and this guide for [ETW Manifests](https://msdn.microsoft.com/en-us/library/dd996930%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396).
9+
- Edit the [Event manifest](../../src/coreclr/vm/ClrEtwAll.man) to add a new event. For guidelines on adding new events, take a look at the existing events in the manifest and this guide for [ETW Manifests](https://msdn.microsoft.com/en-us/library/dd996930%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396).
1010
- The build system should automatically generate the required artifacts for the added events.
11-
- Add entries in the [exclusion list](../../src/coreclr/src/vm/ClrEtwAllMeta.lst) if necessary
11+
- Add entries in the [exclusion list](../../src/coreclr/vm/ClrEtwAllMeta.lst) if necessary
1212
- The Event Logging Mechanism provides the following two functions, which can be used within the VM:
1313
- **FireEtw**EventName, this is used to trigger the event
1414
- **EventEnabled**EventName, this is used to see if any consumer has subscribed to this event
1515

1616

1717
# Adding New Logging System
1818

19-
Though the the Event logging system was designed for ETW, the build system provides a mechanism, basically an [adapter script- genEventing.py](../../src/coreclr/src/scripts/genEventing.py) so that other Logging System can be added and used by CoreClr. An Example of such an extension for [LTTng logging system](https://lttng.org/) can be found in [genLttngProvider.py](../../src/coreclr/src/scripts/genLttngProvider.py )
19+
Though the the Event logging system was designed for ETW, the build system provides a mechanism, basically an [adapter script- genEventing.py](../../src/coreclr/scripts/genEventing.py) so that other Logging System can be added and used by CoreClr. An Example of such an extension for [LTTng logging system](https://lttng.org/) can be found in [genLttngProvider.py](../../src/coreclr/scripts/genLttngProvider.py )

docs/coding-guidelines/clr-code-guide.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Rules can either be imposed by invariants or team policy.
105105

106106
Team policy rules are not necessarily less important than invariants. For example, the rule to use [safemath.h][safemath.h] rather that coding your own integer overflow check is a policy rule. But because it deals with security, we'd probably treat it as higher priority than a very obscure (non-security) related bug.
107107

108-
[safemath.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/inc/safemath.h
108+
[safemath.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/inc/safemath.h
109109

110110
One type of rule you won't find here are purely syntactic "code formatting" rules such as brace placement. While there is value in uniform stylistic conventions, we don't want to "lay down the law" on these to the extent that we do for the more semantic-oriented issues covered here. The rules included in this document are here because breaking them would do one of the following:
111111

@@ -238,8 +238,8 @@ The solution is the OBJECTHANDLE. OBJECTHANDLE allocates a location from special
238238

239239
Handles are implemented through several layers of abstraction – the "official" interface for public use is the one described here and is exposed through [objecthandle.h][objecthandle.h]. Don't confuse this with [handletable.h][handletable.h] which contains the internals. The CreateHandle() api allocates a new location. ObjectFromHandle() dereferences the handle and returns an up-to-date reference. DestroyHandle() frees the location.
240240

241-
[objecthandle.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/gc/objecthandle.h
242-
[handletable.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/gc/handletable.h
241+
[objecthandle.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/gc/objecthandle.h
242+
[handletable.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/gc/handletable.h
243243

244244
The following code fragment shows how handles are used. In practice, of course, people use GCPROTECT rather than handles for situations this simple.
245245

@@ -551,7 +551,7 @@ First, look for a prebaked holder that does what you want. Some common ones are
551551

552552
If no existing holder fits your need, make one. If it's your first holder, start by reading [src\inc\holder.h][holder.h]. Decide if you want a holder or a wrapper. If you don't do much with a resource except acquire and release it, use a holder. Otherwise, you want the wrapper since its overloaded operators make it much easier to replace the resource variable with the wrapper.
553553

554-
[holder.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/inc/holder.h
554+
[holder.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/inc/holder.h
555555

556556
Instantiate the holder or wrapper template with the required parameters. You must supply the data type being managed, the RELEASE function, the default value for uninitialized constructions, the IS_NULL function and the ACQUIRE function. Unless you're implementing a critical section holder, you can probably supply a NOP for ACQUIRE . Most resources can't be meaningfully released and reacquired so it's easier to allocate the resource outside the holder and pass it in through its constructor. For convenience, [holder.h][holder.h] defines a DoNothing<Type> template that creates a NOP ACQUIRE function for any given resource type. There are also convenience templates for writing RELEASE functions. See [holder.h][holder.h] for their definitions and examples of their use.
557557

@@ -716,7 +716,7 @@ SString is the abstraction to use for unmanaged strings in CLR code. It is impor
716716

717717
This section will provide an overview for SString. For specific details on methods and use, see the file [src\inc\sstring.h][sstring.h]. SString has been in use in our codebase for quite a few years now so examples of its use should be easy to find.
718718

719-
[sstring.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/inc/sstring.h
719+
[sstring.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/inc/sstring.h
720720

721721
An SString object represents a Unicode string. It has its own buffer which it internally manages. The string buffer is typically not referenced directly by user code; instead the string is manipulated indirectly by methods defined on SString. Ultimately there are several ways to get at the raw string buffer if such functionality is needed to interface to existing APIs. But these should be used only when absolutely necessary.
722722

@@ -822,7 +822,7 @@ We used to assign levels manually, but this leads to problems when it comes time
822822

823823
Instead we now record the explicit dependencies as a set of rules in the src\inc\CrstTypes.def file and use a tool to automatically assign compatible levels to each Crst type. See CrstTypes.def for a description of the rule syntax and other instructions for updating Crst types.
824824

825-
[crst.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/vm/crst.h
825+
[crst.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/vm/crst.h
826826

827827
### <a name="2.6.3"></a>2.6.3 Creating Crsts
828828

@@ -1034,7 +1034,7 @@ Here are some immediate tips for working well with the managed-debugging service
10341034
- GetFoo() - fails if a Foo does not exist. Being non-mutating, this should also be GC_NOTRIGGER. Non-mutating will also make it much easier to DAC-ize. This is what the debugger will call.
10351035
- and GetOrCreateFoo() that is built around GetFoo(). The rest of the runtime can call this.
10361036
- The debugger can then just call GetFoo(), and deal with the failure accordingly.
1037-
- If you add a new stub (or way to call managed code), make sure that you can source-level step-in (F11) it under the debugger. The debugger is not psychic. A source-level step-in needs to be able to go from the source-line before a call to the source-line after the call, or managed code developers will be very confused. If you make that call transition be a giant 500 line stub, you must cooperate with the debugger for it to know how to step-through it. (This is what StubManagers are all about. See [src\vm\stubmgr.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/src/vm/stubmgr.h)). Try doing a step-in through your new codepath under the debugger.
1037+
- If you add a new stub (or way to call managed code), make sure that you can source-level step-in (F11) it under the debugger. The debugger is not psychic. A source-level step-in needs to be able to go from the source-line before a call to the source-line after the call, or managed code developers will be very confused. If you make that call transition be a giant 500 line stub, you must cooperate with the debugger for it to know how to step-through it. (This is what StubManagers are all about. See [src\vm\stubmgr.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/vm/stubmgr.h)). Try doing a step-in through your new codepath under the debugger.
10381038
- **Beware of timeouts** : The debugger may completely suspend your process at arbitrary points. In most cases, the debugger will do the right thing (and suspend your timeout too), but not always. For example, if you have some other process waiting for info from the debuggee, it [may hit a timeout](https://docs.microsoft.com/en-us/archive/blogs/jmstall/why-you-sometimes-get-a-bogus-contextswitchdeadlock-mda-under-the-debugger).
10391039
- **Use CLR synchronization primitives (like Crst)**. In addition to all the reasons listed in the synchronization section, the CLR-aware primitives can cooperate with the debugging services. For example:
10401040
- The debugger needs to know when threads are modifying sensitive data (which correlates to when the threads lock that data).
@@ -1057,7 +1057,7 @@ Here are some immediate tips for working well with the managed-debugging service
10571057

10581058
Because the CLR is ultimately compiled on several different platforms, we have to be careful about the primitive types which are used in our code. Some compilers can have slightly different declarations in standard header files, and different processor word sizes can require values to have different representations on different platforms.
10591059

1060-
Because of this, we have gathered definition all of the "blessed" CLR types in a single header file, [clrtypes.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/src/inc/clrtypes.h). In general, you should only use primitive types which are defined in this file. As an exception, you may use built-in primitive types like int and short when precision isn't particularly interesting.
1060+
Because of this, we have gathered definition all of the "blessed" CLR types in a single header file, [clrtypes.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/inc/clrtypes.h). In general, you should only use primitive types which are defined in this file. As an exception, you may use built-in primitive types like int and short when precision isn't particularly interesting.
10611061

10621062
The types are grouped into several categories.
10631063

@@ -1133,7 +1133,7 @@ This item asserts that the thread is in a particular mode or declares that the f
11331133

11341134
#### <a name="2.10.1.5"></a>2.10.1.5 LOADS_TYPE(_loadlevel_)
11351135

1136-
This item asserts that the function may invoke the loader and cause a type to loaded up to (and including) the indicated loadlevel. Valid load levels are taken from ClassLoadLevel enumerationin [classLoadLevel.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/src/vm/classloadlevel.h).
1136+
This item asserts that the function may invoke the loader and cause a type to loaded up to (and including) the indicated loadlevel. Valid load levels are taken from ClassLoadLevel enumerationin [classLoadLevel.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/vm/classloadlevel.h).
11371137

11381138
The CLR asserts if any attempt is made to load a type past the current limit set by LOADS_TYPE. A call to any function that has a LOADS_TYPE contract is treated as an attempt to load a type up to that limit.
11391139

@@ -1143,7 +1143,7 @@ These declare whether a function or callee takes any kind of EE or user lock: Cr
11431143

11441144
In TLS we keep track of the current intent (whether to lock), and actual reality (what locks are actually taken). Enforcement occurs as follows:
11451145

1146-
[contract.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/src/inc/contract.h
1146+
[contract.h]: https://github.com/dotnet/runtime/blob/master/src/coreclr/inc/contract.h
11471147

11481148
- SCAN
11491149
- A CANNOT_TAKE_LOCK function calling a CAN_TAKE_LOCK function is illegal (just like THROWS/NOTHROWS)
@@ -1258,4 +1258,4 @@ At a high level, DAC is a technique to enable execution of CLR algorithms from o
12581258

12591259
Various tools (most notably the debugger and SOS) rely on portions of the CLR code being properly "DACized". Writing code in this way can be tricky and error-prone. Use the following references for more details:
12601260

1261-
- The best documentation is in the code itself. See the large comments at the top of [src\inc\daccess.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/src/inc/daccess.h).
1261+
- The best documentation is in the code itself. See the large comments at the top of [src\inc\daccess.h](https://github.com/dotnet/runtime/blob/master/src/coreclr/inc/daccess.h).

0 commit comments

Comments
 (0)