Clone error: Failed to resolve path `git@github.com:<...>`

[nstiurca]

Per docs, I should be able to josh clone an SSH-accessible repo. However,

$ josh clone git@github.com:josh-project/josh.git :/ josh
Error: Failed to resolve path git@github.com:josh-project/josh.git
Failed to resolve path git@github.com:josh-project/josh.git
No such file or directory (os error 2)
$ josh --version
josh ba5ea29f

(ba5ea29f is of course the recently tagged r26.04.19 release)

What am I missing?

[christian-schilling]

josh clone ssh://git@github.com:josh-project/josh.git :/ josh
Should work.
Sorry for docs not being specific regarding that.. Will fix.

[nstiurca]

Interesting. I thought I tried that, but maybe I had a typo?

Still, GH cloning practices often just use URIs starting with git@, and as such I expect that to just work.

I just sent you a patch to that effect. Though it also sounds like maybe internally you'd prefer to prefix such paths with ssh://?

[nstiurca]

Just double checked, and prepending ssh:// creates other problems.

$ josh clone ssh://git@github.com:josh-project/josh.git :/ /tmp/josh
Added remote 'origin' with filter ':/'
ssh: Could not resolve hostname github.com:josh-project: Name or service not known
fatal: Could not read from remote repository.

Interestingly, ssh://git@github.com/josh-project/josh.git as the URI works (note replacing the : after the hostname with /) but that that point it's two edits away from the link GH provides for users.

[christian-schilling]

The docs say "URL" and the git@... is not an URL.
It seems cargo has/had similar issues:
rust-lang/cargo#3014
rust-lang/cargo#1851

I think the correct fix is to validate the the command line arg to be valid URL and print a proper error if it is not.
Also github.com advertising the legacy SCP like syntax should be considered a github bug. (can it be filed somewhere?)
We can do what git does and normalize the SCP like syntax to a proper url to store in the config.